[GitHub] [pulsar] detailyang commented on a change in pull request #13467: fix: bug when allAll bucket

[GitBox <gi...@apache.org>]

detailyang commented on a change in pull request #13467:
URL: https://github.com/apache/pulsar/pull/13467#discussion_r774423411



##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/util/TestStatsBuckets.java
##########
@@ -99,4 +99,17 @@ public void test() {
         assertEquals(stats.getCount(), 3);
         assertEquals(stats.getBuckets(), new long[] { 1, 0, 1, 1 });
     }
+
+    @Test
+    public void testAddAll() {
+        StatsBuckets stats = new StatsBuckets(10, 20, 30);
+        stats.addValue(1);
+        stats.addValue(2);
+        stats.refresh();
+        StatsBuckets stats2=new StatsBuckets(10, 20, 30);

Review comment:
       `StatsBuckets stats2 = new StatsBuckets(10, 20, 30);` will be better:)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org