You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 10:15:54 UTC

[GitHub] [spark] maropu commented on pull request #29692: [SPARK-32830][SQL] Optimize Skewed BroadcastNestedLoopJoin with AQE

maropu commented on pull request #29692:
URL: https://github.com/apache/spark/pull/29692#issuecomment-690134842


   Ah, one more comment; could you update the code comment in `OptimizeSkewedJoin`? It looks most comments assume smj only, e.g.,  https://github.com/apache/spark/pull/29692/files#diff-2d6bea6eed43ca6f37fe3531cb574069R151


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org