You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/07 01:36:58 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4797: Disable
compression when numPartitions are less than the threshold
codecov-io commented on issue #4797: Disable compression when numPartitions are less than the threshold
URL: https://github.com/apache/incubator-pinot/pull/4797#issuecomment-550579885
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=h1) Report
> Merging [#4797](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/aba5482f87e96d41e0b0ee9e403ecdb4a7eeece6?src=pr&el=desc) will **decrease** coverage by `12.12%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4797 +/- ##
=============================================
- Coverage 49.84% 37.72% -12.13%
=============================================
Files 1211 1211
Lines 65572 65572
Branches 9559 9560 +1
=============================================
- Hits 32684 24734 -7950
- Misses 30314 38597 +8283
+ Partials 2574 2241 -333
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/pinot/common/utils/helix/HelixHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==) | `34.13% <33.33%> (-15.57%)` | `0 <0> (ø)` | |
| [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...nullvalue/RealtimeNullValueVectorReaderWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL251bGx2YWx1ZS9SZWFsdGltZU51bGxWYWx1ZVZlY3RvclJlYWRlcldyaXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...n/function/PercentileEstMVAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlRXN0TVZBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ransformer/timeunit/CustomTimeUnitTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vdHJhbnNmb3JtZXIvdGltZXVuaXQvQ3VzdG9tVGltZVVuaXRUcmFuc2Zvcm1lci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PcHRpb25zQXN0Tm9kZS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ot/core/query/scheduler/TableBasedGroupMapper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvVGFibGVCYXNlZEdyb3VwTWFwcGVyLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...t/core/segment/index/readers/OnHeapDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRGljdGlvbmFyeS5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...mmon/config/instance/InstanceAssignmentConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [732 more](https://codecov.io/gh/apache/incubator-pinot/pull/4797/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=footer). Last update [aba5482...679d6bf](https://codecov.io/gh/apache/incubator-pinot/pull/4797?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org