You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/22 16:34:34 UTC
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5410: CloudStack fails to migrate VM with volume when there are datadisks attatched
GutoVeronezi commented on a change in pull request #5410:
URL: https://github.com/apache/cloudstack/pull/5410#discussion_r714116952
##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##########
@@ -83,26 +82,51 @@
@Override
protected StrategyPriority internalCanHandle(Map<VolumeInfo, DataStore> volumeMap, Host srcHost, Host destHost) {
if (super.internalCanHandle(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
- if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
- Set<VolumeInfo> volumeInfoSet = volumeMap.keySet();
+ if (isKvmNfsStorageMigration(volumeMap, srcHost, destHost) || isLocalStorageMigration(volumeMap)) {
Review comment:
We could join these `if` statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org