You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alastair Maw (JIRA)" <ji...@apache.org> on 2007/03/16 15:27:09 UTC
[jira] Created: (WICKET-396) Wicket.Focus code utterly breaks
AjaxEditableLabel
Wicket.Focus code utterly breaks AjaxEditableLabel
--------------------------------------------------
Key: WICKET-396
URL: https://issues.apache.org/jira/browse/WICKET-396
Project: Wicket
Issue Type: Bug
Components: wicket, wicket-extensions
Reporter: Alastair Maw
Assigned To: Johan Compagner
The Wicket.Focus javascript is nice and clever, but isn't clever enough - we've overlooked the use case where people want to set the focus in their AJAX callback to another component.
This is particularly bad for the AjaxEditableLabel case, because onblur() on the text field that it pops up causes it to submit the value back to the server and finish the editing process and go away. So the text field pops up, and then wicket moves the focus somewhere else, so it goes away again immediately. :-(
Maybe a good stab at fixing 90% of the problem would be to see if the JS in the response has the word "focus" in it, and not do the focusing if it does?
Looking at the user list, I think Johan is the Wicket.Focus man, so I'm assigning this to him. Johan - if this isn't really your domain, obviously feel free to unassign and accept my apologies. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-396) Wicket.Focus code utterly breaks
AjaxEditableLabel
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-396:
--------------------------------
Assignee: Alastair Maw (was: Johan Compagner)
Quite possibly. I guess the AjaxEditableLabel code needs updating with that if so. I'll have a look at this ASAP.
> Wicket.Focus code utterly breaks AjaxEditableLabel
> --------------------------------------------------
>
> Key: WICKET-396
> URL: https://issues.apache.org/jira/browse/WICKET-396
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.3
> Reporter: Alastair Maw
> Assigned To: Alastair Maw
> Fix For: 1.3
>
>
> The Wicket.Focus javascript is nice and clever, but isn't clever enough - we've overlooked the use case where people want to set the focus in their AJAX callback to another component.
> This is particularly bad for the AjaxEditableLabel case, because onblur() on the text field that it pops up causes it to submit the value back to the server and finish the editing process and go away. So the text field pops up, and then wicket moves the focus somewhere else, so it goes away again immediately. :-(
> Maybe a good stab at fixing 90% of the problem would be to see if the JS in the response has the word "focus" in it, and not do the focusing if it does?
> Looking at the user list, I think Johan is the Wicket.Focus man, so I'm assigning this to him. Johan - if this isn't really your domain, obviously feel free to unassign and accept my apologies. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-396) Wicket.Focus code utterly breaks
AjaxEditableLabel
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-396.
---------------------------------
Resolution: Fixed
Fixed in r534980.
> Wicket.Focus code utterly breaks AjaxEditableLabel
> --------------------------------------------------
>
> Key: WICKET-396
> URL: https://issues.apache.org/jira/browse/WICKET-396
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.3
> Reporter: Alastair Maw
> Assigned To: Alastair Maw
> Fix For: 1.3
>
>
> The Wicket.Focus javascript is nice and clever, but isn't clever enough - we've overlooked the use case where people want to set the focus in their AJAX callback to another component.
> This is particularly bad for the AjaxEditableLabel case, because onblur() on the text field that it pops up causes it to submit the value back to the server and finish the editing process and go away. So the text field pops up, and then wicket moves the focus somewhere else, so it goes away again immediately. :-(
> Maybe a good stab at fixing 90% of the problem would be to see if the JS in the response has the word "focus" in it, and not do the focusing if it does?
> Looking at the user list, I think Johan is the Wicket.Focus man, so I'm assigning this to him. Johan - if this isn't really your domain, obviously feel free to unassign and accept my apologies. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-396) Wicket.Focus code utterly breaks
AjaxEditableLabel
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481894 ]
Johan Compagner commented on WICKET-396:
----------------------------------------
see AjaxRequestTarget.focusComponent() (or something like that)
I use that in my own project all the time., onbluf of textfield1 -> change focus to textfield10. Should work fine.
Isn't that what you want?
> Wicket.Focus code utterly breaks AjaxEditableLabel
> --------------------------------------------------
>
> Key: WICKET-396
> URL: https://issues.apache.org/jira/browse/WICKET-396
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.3
> Reporter: Alastair Maw
> Assigned To: Johan Compagner
> Fix For: 1.3
>
>
> The Wicket.Focus javascript is nice and clever, but isn't clever enough - we've overlooked the use case where people want to set the focus in their AJAX callback to another component.
> This is particularly bad for the AjaxEditableLabel case, because onblur() on the text field that it pops up causes it to submit the value back to the server and finish the editing process and go away. So the text field pops up, and then wicket moves the focus somewhere else, so it goes away again immediately. :-(
> Maybe a good stab at fixing 90% of the problem would be to see if the JS in the response has the word "focus" in it, and not do the focusing if it does?
> Looking at the user list, I think Johan is the Wicket.Focus man, so I'm assigning this to him. Johan - if this isn't really your domain, obviously feel free to unassign and accept my apologies. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-396) Wicket.Focus code utterly breaks
AjaxEditableLabel
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-396:
--------------------------------
Fix Version/s: 1.3
Affects Version/s: 1.3
> Wicket.Focus code utterly breaks AjaxEditableLabel
> --------------------------------------------------
>
> Key: WICKET-396
> URL: https://issues.apache.org/jira/browse/WICKET-396
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.3
> Reporter: Alastair Maw
> Assigned To: Johan Compagner
> Fix For: 1.3
>
>
> The Wicket.Focus javascript is nice and clever, but isn't clever enough - we've overlooked the use case where people want to set the focus in their AJAX callback to another component.
> This is particularly bad for the AjaxEditableLabel case, because onblur() on the text field that it pops up causes it to submit the value back to the server and finish the editing process and go away. So the text field pops up, and then wicket moves the focus somewhere else, so it goes away again immediately. :-(
> Maybe a good stab at fixing 90% of the problem would be to see if the JS in the response has the word "focus" in it, and not do the focusing if it does?
> Looking at the user list, I think Johan is the Wicket.Focus man, so I'm assigning this to him. Johan - if this isn't really your domain, obviously feel free to unassign and accept my apologies. :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.