You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by Martin Koci <ma...@gmail.com> on 2011/05/30 16:16:13 UTC

[core] support implicit object 'component' in renderers where getRendersChildren is true

Hi,

problem described in MYFACES-3157 applies for all cases where renderer
reads property from child component. I think that only correct way in
push child to EL before:

child.pushComponentToEL()
Object value = child.getValue();
String style = child.getStyle();
child.popComponentFromEL()

Is that ok? This affects about 8 renderers in myfaces-impl/shared

Kočičák

Re: [core] support implicit object 'component' in renderers where getRendersChildren is true

Posted by Leonardo Uribe <lu...@gmail.com>.

Hi

I think it is correct to do that. After all, it will not cause any
side effects., but I it could be better if you wrap those calls in a
try {} finally block.

regards,

Leonardo Uribe

2011/5/30 Martin Koci <ma...@gmail.com>:
> Hi,
>
> problem described in MYFACES-3157 applies for all cases where renderer
> reads property from child component. I think that only correct way in
> push child to EL before:
>
> child.pushComponentToEL()
> Object value = child.getValue();
> String style = child.getStyle();
> child.popComponentFromEL()
>
> Is that ok? This affects about 8 renderers in myfaces-impl/shared
>
> Kočičák
>
>