You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 07:54:39 UTC

[GitHub] [arrow-rs] roee88 commented on a change in pull request #317: Add (simd) modulus op

roee88 commented on a change in pull request #317:
URL: https://github.com/apache/arrow-rs/pull/317#discussion_r637759010



##########
File path: arrow/src/compute/kernels/arithmetic.rs
##########
@@ -348,6 +444,40 @@ where
     Ok(PrimitiveArray::<T>::from(data))
 }
 
+/// SIMD vectorized implementation of `left % right`.
+/// If any of the lanes marked as valid in `valid_mask` are `0` then an `ArrowError::ModulusByZero`
+/// is returned. The contents of no-valid lanes are undefined.
+#[cfg(simd)]

Review comment:
       Just a comment. You will need to rebase and change `simd` to `feature = "simd"` in cfg attributes. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org