You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "bipinprasad (via GitHub)" <gi...@apache.org> on 2023/09/01 07:43:17 UTC
[PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
bipinprasad opened a new pull request, #3578:
URL: https://github.com/apache/storm/pull/3578
## What is the purpose of the change
*storm-sql-core extract javacc parser definition from Calcite jar, adds it to distribution, then used javacc to generate classes that parser definition file. These java classes are then used in storm-sql-core. Eclipse does not properly recognize and execute these steps and then shows errors because of missing generated classes.*
## How was the change tested
*Review the project in project explorer tab in eclipse and ensure that errors are gone. Also do a "mvn clean install" to ensure that maven build is not broken.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by Alexandre Vermeerbergen <av...@gmail.com>.
Hi Bipin,
That will be wonderful if you find the way to fix these last 3 errors
in pom.xml files, thanks !!
By the way, I never experienced Eclipse IDE being confused about
files' content : just make sure if you edit the file outside Eclipse
IDE to use "Refresh" (when I doubt, I select all projects from Package
Explorer view, and I use [F5] to get everything on filesystem synced
to Eclipse IDE).
Kind regards,
Alexandre
Le ven. 1 sept. 2023 à 12:30, Bipin Prasad
<bi...@yahoo.com.invalid> a écrit :
>
> Yes, I have fixes for those. They will be up there shortly. But at least you are up and running and can use the power of UI.
> One thing surprised me with the latest eclipse - it is very easy for the Editor to get confused about the content of a file (and loose the trailing end of a file). I had to go a couple times in “vi” just to make sure that the file did not end where eclipse screen showed.
>
>
> Sent from Yahoo Mail for iPhone
>
>
> On Friday, September 1, 2023, 8:53 AM, Alexandre Vermeerbergen <av...@gmail.com> wrote:
>
> And by the way, after copying the changes from STORM-3970 (and closing
> storm-cassandra project, for which I'm anticipating low community
> interest, so I'm skipping it), I only have 3 errors left in Eclipse
> IDE for Storm:
>
> On /storm-client/pom.xml:
> line 206 (which just contains <execution> tag) error message is:
> - Plugin execution not covered by lifecycle configuration:
> org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
> (execution: unpack, phase: process-test-resources)
> - Failed to execute mojo
> org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
> {execution: unpack}
> (org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack:unpack:process-test-resources)
>
> On /storm-core/pom.xml:
> line 367 (which just contains <execution> tag) error message is:
> - Failed to execute mojo
> org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies
> {execution: copy-dependencies}
> (org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies:copy-dependencies:package)
>
> On /storm-core/pom.xml:
> line 381 (which just contains <execution> tag) error message is:
> - Failed to execute mojo
> org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack
> {execution: unpack}
> (org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack:unpack:process-test-resources)
>
> What is strange is although there are these 3 last errors, there are
> no more Java compilation errors...
>
> Any idea how to get rid of these 3 last ones (I'm intentionally
> forgetting storm-cassandra) ?
>
> Kind regards,
> Alexandre
>
> Le ven. 1 sept. 2023 à 11:44, avermeer (via GitHub) <gi...@apache.org> a écrit :
> >
> >
> > avermeer commented on PR #3578:
> > URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
> >
> > I verified that this change greatly improves the situation is Eclipse IDE (by manually copying the changes to my local temporary branch for test purposes).
> >
> > May I merge it ?
> >
> >
> > --
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
> >
> > For queries about this service, please contact Infrastructure at:
> > users@infra.apache.org
> >
>
>
>
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by Bipin Prasad <bi...@yahoo.com.INVALID>.
Yes, I have fixes for those. They will be up there shortly. But at least you are up and running and can use the power of UI.
One thing surprised me with the latest eclipse - it is very easy for the Editor to get confused about the content of a file (and loose the trailing end of a file). I had to go a couple times in “vi” just to make sure that the file did not end where eclipse screen showed.
Sent from Yahoo Mail for iPhone
On Friday, September 1, 2023, 8:53 AM, Alexandre Vermeerbergen <av...@gmail.com> wrote:
And by the way, after copying the changes from STORM-3970 (and closing
storm-cassandra project, for which I'm anticipating low community
interest, so I'm skipping it), I only have 3 errors left in Eclipse
IDE for Storm:
On /storm-client/pom.xml:
line 206 (which just contains <execution> tag) error message is:
- Plugin execution not covered by lifecycle configuration:
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
(execution: unpack, phase: process-test-resources)
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack:unpack:process-test-resources)
On /storm-core/pom.xml:
line 367 (which just contains <execution> tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies
{execution: copy-dependencies}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies:copy-dependencies:package)
On /storm-core/pom.xml:
line 381 (which just contains <execution> tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack:unpack:process-test-resources)
What is strange is although there are these 3 last errors, there are
no more Java compilation errors...
Any idea how to get rid of these 3 last ones (I'm intentionally
forgetting storm-cassandra) ?
Kind regards,
Alexandre
Le ven. 1 sept. 2023 à 11:44, avermeer (via GitHub) <gi...@apache.org> a écrit :
>
>
> avermeer commented on PR #3578:
> URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
>
> I verified that this change greatly improves the situation is Eclipse IDE (by manually copying the changes to my local temporary branch for test purposes).
>
> May I merge it ?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by Alexandre Vermeerbergen <av...@gmail.com>.
And by the way, after copying the changes from STORM-3970 (and closing
storm-cassandra project, for which I'm anticipating low community
interest, so I'm skipping it), I only have 3 errors left in Eclipse
IDE for Storm:
On /storm-client/pom.xml:
line 206 (which just contains <execution> tag) error message is:
- Plugin execution not covered by lifecycle configuration:
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
(execution: unpack, phase: process-test-resources)
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack:unpack:process-test-resources)
On /storm-core/pom.xml:
line 367 (which just contains <execution> tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies
{execution: copy-dependencies}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies:copy-dependencies:package)
On /storm-core/pom.xml:
line 381 (which just contains <execution> tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack:unpack:process-test-resources)
What is strange is although there are these 3 last errors, there are
no more Java compilation errors...
Any idea how to get rid of these 3 last ones (I'm intentionally
forgetting storm-cassandra) ?
Kind regards,
Alexandre
Le ven. 1 sept. 2023 à 11:44, avermeer (via GitHub) <gi...@apache.org> a écrit :
>
>
> avermeer commented on PR #3578:
> URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
>
> I verified that this change greatly improves the situation is Eclipse IDE (by manually copying the changes to my local temporary branch for test purposes).
>
> May I merge it ?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by "avermeer (via GitHub)" <gi...@apache.org>.
avermeer commented on PR #3578:
URL: https://github.com/apache/storm/pull/3578#issuecomment-1703022984
Merging done!
But I cannot close the JIRA https://issues.apache.org/jira/projects/STORM/issues/STORM-3970?filter=allopenissues, as it is owned by Bipin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by "avermeer (via GitHub)" <gi...@apache.org>.
avermeer commented on PR #3578:
URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
I verified that this change greatly improves the situation is Eclipse IDE (by manually copying the changes to my local temporary branch for test purposes).
May I merge it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by "avermeer (via GitHub)" <gi...@apache.org>.
avermeer merged PR #3578:
URL: https://github.com/apache/storm/pull/3578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3578:
URL: https://github.com/apache/storm/pull/3578#issuecomment-1703016184
Go ahead + close the Jira 🫠
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3578:
URL: https://github.com/apache/storm/pull/3578#issuecomment-1703064106
I closed it. With the addition to the PMC, you should have enough Karma for Jira stuff. If not, we need to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org