[GitHub] [spark] zero323 commented on pull request #40338: [MINOR][PYTHON] Change TypeVar to private symbols

["zero323 (via GitHub)" <gi...@apache.org>]

zero323 commented on PR #40338:
URL: https://github.com/apache/spark/pull/40338#issuecomment-1469912441

   > cc @zero323 in case you have some feedback on this.
   
   @HyukjinKwon I am OK with that, though there is a bigger issue here. We have `TypeVars` in `py` modules in quite a few places, which are a side effect of migrating to inline hints before dropping Python 3.8 support (looking at you, `Protocol`...). 
   
   Ideally, we'd handle all of that consistently and use consistent naming convention, but that's not something will be able to do any time soon.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org