You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@slider.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/07/16 21:47:08 UTC
[jira] [Commented] (SLIDER-242) exportGroups retrieval can be
lifted outside nested loop in AgentProviderService#processReturnedStatus()
[ https://issues.apache.org/jira/browse/SLIDER-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063984#comment-14063984 ]
ASF subversion and git services commented on SLIDER-242:
--------------------------------------------------------
Commit 57098509c5888372cf099212384dd4f7263db664 in incubator-slider's branch refs/heads/develop from [~tedyu]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;h=5709850 ]
SLIDER-242 exportGroups retrieval can be lifted outside nested loop in AgentProviderService#processReturnedStatus()
> exportGroups retrieval can be lifted outside nested loop in AgentProviderService#processReturnedStatus()
> --------------------------------------------------------------------------------------------------------
>
> Key: SLIDER-242
> URL: https://issues.apache.org/jira/browse/SLIDER-242
> Project: Slider
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
>
> Inside the nested loop:
> {code}
> for (ComponentStatus status : statuses) {
> log.info("Status report: " + status.toString());
> if (status.getConfigs() != null) {
> for (String key : status.getConfigs().keySet()) {
> {code}
> I see:
> {code}
> Application application = getMetainfo().getApplication();
> List<ExportGroup> exportGroups = application.getExportGroups();
> {code}
> But getMetainfo() is not related to the status variable. The above lines can be lifted outside the nested loop
--
This message was sent by Atlassian JIRA
(v6.2#6252)