[jira] Updated: (SOLR-1682) Implement CollapseComponent

["Martijn van Groningen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martijn van Groningen updated SOLR-1682:
----------------------------------------

    Attachment: SOLR-1682.patch

Shalin, I tried your patch out and I ran into a few problems with sorting and the collapse counts which turned out to be bugs.
# When I was sorting in ascending order(on a field or score), the order was itself was incorrect.
# The collapse count was always one (when threshold=1 which is default was specified). I suppose the count should increment every time a document is collapsed.

I fixed these issues in the new patch and added tests that show that.

Though I have a question about the response format. When collapse.threshold is > 1 and more than one documents is collapsed then the collapse.count is named group.size. The field group.numFound is then added as well. Why did you gave it a different name?

When collapse.threshold is larger than one two collectors are used. I understand that in both situations a different algorithm is used. But now also a search is done twice. Shouldn't it be better to have two complete distinct collectors that don't depend on one another?

> Implement CollapseComponent
> ---------------------------
>
>                 Key: SOLR-1682
>                 URL: https://issues.apache.org/jira/browse/SOLR-1682
>             Project: Solr
>          Issue Type: Sub-task
>          Components: search
>            Reporter: Martijn van Groningen
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.5
>
>         Attachments: field-collapsing.patch, SOLR-1682.patch, SOLR-236.patch
>
>
> Child issue of SOLR-236. This issue is dedicated to field collapsing in general and all its code (CollapseComponent, DocumentCollapsers and CollapseCollectors). The main goal is the finalize the request parameters and response format.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.