You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2019/09/18 12:37:00 UTC
[jira] [Comment Edited] (SOLR-13775) Update PR template to suggest
Githubs: "Allow Edits From Maintainers" option
[ https://issues.apache.org/jira/browse/SOLR-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932385#comment-16932385 ]
Jason Gerlowski edited comment on SOLR-13775 at 9/18/19 12:36 PM:
------------------------------------------------------------------
As a first pass at this, I would put the checklist item:
* I have given Solr maintainers [access|https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork] to contribute to my PR branch.
near the top of the list, right under "I have reviewed the guidelines for How to Contribute...".
As a part of this JIRA, we should also add a similar notice to the How-to-Contribute docs, with a little more detail.
was (Author: gerlowskija):
As a first pass at this, I would put the checklist item:
* I have given Solr maintainers [access|https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork] to contribute to my PR branch.
near the top of the list, right under "I have reviewed the guidelines for How to Contribute...".
> Update PR template to suggest Githubs: "Allow Edits From Maintainers" option
> ----------------------------------------------------------------------------
>
> Key: SOLR-13775
> URL: https://issues.apache.org/jira/browse/SOLR-13775
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: github
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
>
> As discussed recently on the mailing list, Github does have one big downside: it's pretty onerous for two people to both contribute code to the same PR. PR's typically come from personal-fork's of Solr, owned by an individual. If that individual doesn't think to give other collaborators edit-access, then they must open secondary-PRs to get their changes the primary PR. These secondary PRs must be reviewed, merged etc.
> This makes collaboration much more difficult than it is in the patch world for example, where I can (e.g.) help a contributor clean up their formatting by just uploading a new patch.
> Unfortunately the best workaround at this point for this in github is to prompt those opening PRs to grant access to Solr's upstream committers and maintainers. We can do this by linking users to this [option|https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork] in the "PR checklist" that was added recently.
> Users don't have to provide this access if they don't want. But hopefully it'll many collaboration easier in many cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org