You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/07/01 13:48:33 UTC

Review Request 70984: Added a test for 'suppressOffers(roles)'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70984/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9849
    https://issues.apache.org/jira/browse/MESOS-9849


Repository: mesos


Description
-------

Added a test for 'suppressOffers(roles)'.


Diffs
-----

  src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da 


Diff: https://reviews.apache.org/r/70984/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko

Re: Review Request 70984: Added a test for 'suppressOffers(roles)'.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70984/#review216370
-----------------------------------------------------------


Fix it, then Ship it!




For this and the other test, let's clarify the commit message:

> Added a scheduler driver test for 'suppressOffers(roles)'.


src/tests/scheduler_driver_tests.cpp
Lines 543-546 (patched)
<https://reviews.apache.org/r/70984/#comment303569>

    This looks racy, we should settle to ensure the suppress is processed before adding the agent? Otherwise the offer can go to role1.


- Benjamin Mahler


On July 1, 2019, 1:48 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70984/
> -----------------------------------------------------------
> 
> (Updated July 1, 2019, 1:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9849
>     https://issues.apache.org/jira/browse/MESOS-9849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for 'suppressOffers(roles)'.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_driver_tests.cpp 46af8d2c0fff15974b028521d1434e67bd9217da 
> 
> 
> Diff: https://reviews.apache.org/r/70984/diff/1/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="*SchedulerDriver*SuppressSingleRole*" --gtest_break_on_failure --gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>