You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/25 11:43:34 UTC
[GitHub] [incubator-doris] hf200012 opened a new pull request #7485: Modify the maximum number of records written by Spark/Flink connector each time. The default value is 1000.
hf200012 opened a new pull request #7485:
URL: https://github.com/apache/incubator-doris/pull/7485
Modify the maximum number of records written by Spark/Flink connector each time. The default value is 1000.
## Proposed changes
Close related #issue (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7485: Modify the maximum number of records written by Spark/Flink connector each time. The default value is 1000.
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7485:
URL: https://github.com/apache/incubator-doris/pull/7485#discussion_r775137129
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -28,7 +28,7 @@
public class DorisExecutionOptions implements Serializable {
private static final long serialVersionUID = 1L;
- public static final Integer DEFAULT_BATCH_SIZE = 1000;
+ public static final Integer DEFAULT_BATCH_SIZE = 10000;
public static final Integer DEFAULT_MAX_RETRY_TIMES = 3;
Review comment:
I think the `DEFAULT_MAX_RETRY_TIMES` can be set to 1 to avoid too many unnecessary retries.
If `DEFAULT_MAX_RETRY_TIMES` is 1, it will only retry once.
##########
File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
##########
@@ -66,11 +66,9 @@
String DORIS_WRITE_FIELDS = "doris.write.fields";
- String SINK_BATCH_SIZE = "sink.batch.size";
String DORIS_SINK_BATCH_SIZE = "doris.sink.batch.size";
- int SINK_BATCH_SIZE_DEFAULT = 1024;
+ int SINK_BATCH_SIZE_DEFAULT = 10000;
- String SINK_MAX_RETRIES = "sink.max-retries";
String DORIS_SINK_MAX_RETRIES = "doris.sink.max-retries";
int SINK_MAX_RETRIES_DEFAULT = 3;
Review comment:
Set `SINK_MAX_RETRIES_DEFAULT` to 1, same as flink connector.
And we also need to modify `DorisStreamLoadSink.scala`, because when `SINK_MAX_RETRIES_DEFAULT` is 1, there is no retry at all. We should keep it consistent with flink connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #7485: Modify the maximum number of records written by Spark/Flink connector each time. The default value is 1000.
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #7485:
URL: https://github.com/apache/incubator-doris/pull/7485#discussion_r775139158
##########
File path: extension/flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisExecutionOptions.java
##########
@@ -28,7 +28,7 @@
public class DorisExecutionOptions implements Serializable {
private static final long serialVersionUID = 1L;
- public static final Integer DEFAULT_BATCH_SIZE = 1000;
+ public static final Integer DEFAULT_BATCH_SIZE = 10000;
public static final Integer DEFAULT_MAX_RETRY_TIMES = 3;
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7485: Modify the maximum number of records written by Spark/Flink connector each time. The default value is 10000.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7485:
URL: https://github.com/apache/incubator-doris/pull/7485#issuecomment-1001029696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on a change in pull request #7485: Modify the maximum number of records written by Spark/Flink connector each time. The default value is 10000.
Posted by GitBox <gi...@apache.org>.
hf200012 commented on a change in pull request #7485:
URL: https://github.com/apache/incubator-doris/pull/7485#discussion_r775139407
##########
File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
##########
@@ -66,11 +66,9 @@
String DORIS_WRITE_FIELDS = "doris.write.fields";
- String SINK_BATCH_SIZE = "sink.batch.size";
String DORIS_SINK_BATCH_SIZE = "doris.sink.batch.size";
- int SINK_BATCH_SIZE_DEFAULT = 1024;
+ int SINK_BATCH_SIZE_DEFAULT = 10000;
- String SINK_MAX_RETRIES = "sink.max-retries";
String DORIS_SINK_MAX_RETRIES = "doris.sink.max-retries";
int SINK_MAX_RETRIES_DEFAULT = 3;
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7485: Modify the maximum number of records written by Spark/Flink connector each time. The default value is 10000.
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7485:
URL: https://github.com/apache/incubator-doris/pull/7485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org