You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/09 07:07:11 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request, #3074: Remove legacy ClientConfiguration code
ctubbsii opened a new pull request, #3074:
URL: https://github.com/apache/accumulo/pull/3074
* Delete ClientConfiguration and unit test
* Update ClientConfConverter to remove legacy client config
* Update ClientConfConverterTest.basic to test conversion directly to/from client Properties and AccumuloConfiguration (which is still needed for some bootstrapping code and SASL configuration code)
* Remove legacy trace props from ClientProperty
* Remove deprecated getClientConfig() methods from minicluster
* No longer write out client config file (only client properties file) and no longer set corresponding `ACCUMULO_CLIENT_CONF_PATH` environment variable for minicluster
* Update SaslServerConnectionParams to remove unused overloaded constructors and setters (allowing secretManager field to be final); this wasn't strictly necessary in this patch, but helped simplify things to make it easier to trace the uses of the ClientConfConverter methods to see how they were still needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3074: Remove legacy ClientConfiguration code
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #3074:
URL: https://github.com/apache/accumulo/pull/3074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3074: Remove legacy ClientConfiguration code
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3074:
URL: https://github.com/apache/accumulo/pull/3074#issuecomment-1309926525
This was very frustrating code to clean up, but I'm confident I've fixed the earlier bugs. I've already confirmed all the hung and failing tests from the first pass are fixed, but I will re-run the full ITs to be sure there's nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3074: Remove legacy ClientConfiguration code
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3074:
URL: https://github.com/apache/accumulo/pull/3074#issuecomment-1310472825
Full ITs finished successfully. Seems unrelated, but saw SaslConnectionParamsTest was a bit flaky in GitHub Actions. I forced it to run in a separate JVM fork from other tests, because it always worked for me when running on its own, so it seems likely another test in the same JVM was interfering with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org