[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #579: chore: improve CI workflows

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #579:
URL: https://github.com/apache/incubator-uniffle/pull/579#discussion_r1102277185


##########
.github/workflows/build.yml:
##########
@@ -48,15 +48,15 @@ jobs:
     uses: ./.github/workflows/sequential.yml
     with:
       maven-args: package -DskipTests
-      cache-key: compile
+      cache-key: package

Review Comment:
   because it should be match `maven-args`, which will give the best approximation for failover.



##########
.github/workflows/build.yml:
##########
@@ -48,15 +48,15 @@ jobs:
     uses: ./.github/workflows/sequential.yml
     with:
       maven-args: package -DskipTests
-      cache-key: compile
+      cache-key: package

Review Comment:
   because it should match `maven-args`, which will give the best approximation for failover.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org