You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cz...@apache.org on 2016/10/12 19:20:07 UTC

svn commit: r1764511 - in /felix/trunk/tools/org.apache.felix.scr.generator: changelog.txt src/main/java/org/apache/felix/scrplugin/helper/Validator.java

Author: cziegeler
Date: Wed Oct 12 19:20:07 2016
New Revision: 1764511

URL: http://svn.apache.org/viewvc?rev=1764511&view=rev
Log:
FELIX-5373 : Improve failure message when enabling metatype and using no or private properties only

Modified:
    felix/trunk/tools/org.apache.felix.scr.generator/changelog.txt
    felix/trunk/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java

Modified: felix/trunk/tools/org.apache.felix.scr.generator/changelog.txt
URL: http://svn.apache.org/viewvc/felix/trunk/tools/org.apache.felix.scr.generator/changelog.txt?rev=1764511&r1=1764510&r2=1764511&view=diff
==============================================================================
--- felix/trunk/tools/org.apache.felix.scr.generator/changelog.txt (original)
+++ felix/trunk/tools/org.apache.felix.scr.generator/changelog.txt Wed Oct 12 19:20:07 2016
@@ -1,5 +1,7 @@
 Changes from 1.15.0 to 1.14.0
 -----------------------------
+** Improvement
+    * [FELIX-5373] - Improve failure message when enabling metatype and using no or private properties only
 ** Bug
     * [FELIX-5304] - SERVICE_PID property should not be created
     * [FELIX-5328] - NoClassDefFound not wrapped in the ClassScanner

Modified: felix/trunk/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java
URL: http://svn.apache.org/viewvc/felix/trunk/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java?rev=1764511&r1=1764510&r2=1764511&view=diff
==============================================================================
--- felix/trunk/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java (original)
+++ felix/trunk/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/Validator.java Wed Oct 12 19:20:07 2016
@@ -186,8 +186,8 @@ public class Validator {
             // additional check for metatype (FELIX-4035)
             if ( this.container.getMetatypeContainer() != null ) {
                 if ( this.container.getMetatypeContainer().getProperties().size() == 0 ) {
-                    this.logError(component, "Component is defined to generate metatype information, however no properties have been " +
-                        "defined; in case no properties are wanted, consider to use 'metatype=false'");
+                    this.logError(component, "Component is defined to generate metatype information, however no properties or only private properties have been " +
+                        "defined; in case no properties or only private properties are wanted, consider to use 'metatype=false'");
                 }
             }
             if (iLog.getNumberOfErrors() == currentIssueCount) {