You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/06/01 19:39:27 UTC
[GitHub] incubator-zeppelin pull request #945: ZEPPELIN-931: fix interpreter listing ...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/945
ZEPPELIN-931: fix interpreter listing bug
### What is this PR for?
Currently available interpreter list is not shown in `Creating New Interpreter` section. It seems this bug was generated after #835 was merged. So I temporally deactivated [3 SerializedName code lines](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/Interpreter.java#L228).
### What type of PR is it?
Bug Fix
### Todos
* [x] - Fix interpreter listing bug when creating new interpreter
### What is the Jira issue?
[ZEPPELIN-931](https://issues.apache.org/jira/browse/ZEPPELIN-931)
### How should this be tested?
1. Build master branch and browse Zeppelin home
2. Create new interpreter -> You can see the available interpreter list in this step
3. Apply this patch
4. Build again and browse -> You can see the available interpreter list except `spark` interpreter.
The reason why you can't see `spark` interpreter in this step is `spark` is classified as `remoteInterpreter` since #835 was merged.
### Screenshots (if appropriate)
- **Before**
<img width="1273" alt="screen shot 2016-06-01 at 12 36 42 pm" src="https://cloud.githubusercontent.com/assets/10060731/15723066/9082435e-27f5-11e6-9783-df44638dbbec.png">
- **After**
<img width="1273" alt="screen shot 2016-06-01 at 12 33 06 pm" src="https://cloud.githubusercontent.com/assets/10060731/15723067/92bcc8ce-27f5-11e6-82f5-6c0db7b4342c.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/945.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #945
----
commit 6d7f1bc43437e8a876eef1a3e36a17fbd5805cb1
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-01T18:56:52Z
ZEPPELIN-931: fix interpreter listing bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #945: [HOTFIX] ZEPPELIN-931: fix interpreter...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #945: ZEPPELIN-931: fix interpreter listing ...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/945
ZEPPELIN-931: fix interpreter listing bug
### What is this PR for?
Currently available interpreter list is not shown in `Creating New Interpreter` section. It seems this bug was generated after #835 was merged. So I temporally deactivated [3 SerializedName code lines](https://github.com/apache/incubator-zeppelin/pull/945/commits/6d7f1bc43437e8a876eef1a3e36a17fbd5805cb1).
### What type of PR is it?
Bug Fix
### Todos
* [x] - Fix interpreter listing bug when creating new interpreter
### What is the Jira issue?
[ZEPPELIN-931](https://issues.apache.org/jira/browse/ZEPPELIN-931)
### How should this be tested?
1. Build latest master branch and browse Zeppelin home
2. Create new interpreter -> You can not see the available interpreter list in this step like below attached screenshot
3. Apply this patch
4. Build again and browse -> You can see the available interpreter list except `spark` interpreter.
The reason why you can't see `spark` interpreter in this step is `spark` was classified as `remoteInterpreter` since #835 was merged.
### Screenshots (if appropriate)
- **Before**
<img width="1273" alt="screen shot 2016-06-01 at 12 36 42 pm" src="https://cloud.githubusercontent.com/assets/10060731/15723066/9082435e-27f5-11e6-9783-df44638dbbec.png">
- **After**
<img width="1273" alt="screen shot 2016-06-01 at 12 33 06 pm" src="https://cloud.githubusercontent.com/assets/10060731/15723067/92bcc8ce-27f5-11e6-82f5-6c0db7b4342c.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/945.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #945
----
commit 6d7f1bc43437e8a876eef1a3e36a17fbd5805cb1
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-01T18:56:52Z
ZEPPELIN-931: fix interpreter listing bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul Yeah sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul Yeah I just added :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: ZEPPELIN-931: fix interpreter listing bug
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@AhyoungRyu Could you please add "[HOTFIX]" in a title?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@AhyoungRyu I've missed something. I submitted a PR, again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul That was also applied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: ZEPPELIN-931: fix interpreter listing bug
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
I don't know whether front-end uses RegisteredInterprerter. We need to find a way to indicate or mark which class is used in front and backend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@Leemoonsoo CI has been passed. Could you check this one ? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: ZEPPELIN-931: fix interpreter listing bug
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@AhyoungRyu I've tested and reproduced what you mentioned. Your change looks simple but it's not perfect because you cannot see spark interpreter in your interpreter list because interpreter-setting.json read `interpreterGroup`, `interpreterName` and `interpreterClassName` while initialisation. I'll submit a PR into your branch. Thanks for reporting this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #945: ZEPPELIN-931: fix interpreter listing ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@AhyoungRyu Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul Let's wait the travis then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: ZEPPELIN-931: fix interpreter listing bug
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul I see. That's why I can't see `Spark` interpreter in the list. Thanks ! Okay i'll check ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul I applied your patch and it works :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: ZEPPELIN-931: fix interpreter listing bug
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
@jongyoul I saw you are working on applying new mechanism to all of the existing interpreters in [ZEPPELIN-804](https://issues.apache.org/jira/browse/ZEPPELIN-804) as subtasks. I think this bug was caused since `interpreterGroup `, `interpreterName` and `interpreterClassName ` that I deactivated was not matched with `group` in [here](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/app/interpreter/interpreter-create/interpreter-create.html#L32). So if you have a better way to solve this bug, just let me know :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #945: [HOTFIX] ZEPPELIN-931: fix interpreter listin...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/945
LGTM. I'll merge it asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---