You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2017/02/07 02:15:17 UTC
Review Request 56361: Add additional tests for the conversion of
TaskStatus.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/
-----------------------------------------------------------
Review request for Aurora and Mehrdad Nurolahzade.
Repository: aurora
Description
-------
This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
Diffs
-----
src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
Diff: https://reviews.apache.org/r/56361/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 56361: Add additional tests for the conversion of
TaskStatus.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164518
-----------------------------------------------------------
Ship it!
Master (cd4df56) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 7, 2017, 2:44 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56361/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:44 a.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
>
> Diff: https://reviews.apache.org/r/56361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 56361: Add additional tests for the conversion of
TaskStatus.
Posted by Mehrdad Nurolahzade <me...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164519
-----------------------------------------------------------
Ship it!
Ship It!
- Mehrdad Nurolahzade
On Feb. 6, 2017, 6:44 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56361/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 6:44 p.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
>
> Diff: https://reviews.apache.org/r/56361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 56361: Add additional tests for the conversion of
TaskStatus.
Posted by Mehrdad Nurolahzade <me...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164517
-----------------------------------------------------------
@ReviewBot retry
- Mehrdad Nurolahzade
On Feb. 6, 2017, 6:44 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56361/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 6:44 p.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
>
> Diff: https://reviews.apache.org/r/56361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 56361: Add additional tests for the conversion of
TaskStatus.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164455
-----------------------------------------------------------
Master (cd4df56) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl
Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$8
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
Test coverage missing for org/apache/aurora/scheduler/TaskVars
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker
Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
Test coverage missing for org/apache/aurora/scheduler/TierModule
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 7.469 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 7, 2017, 2:44 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56361/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:44 a.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
>
> Diff: https://reviews.apache.org/r/56361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 56361: Add additional tests for the conversion of
TaskStatus.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/
-----------------------------------------------------------
(Updated Feb. 6, 2017, 6:44 p.m.)
Review request for Aurora and Mehrdad Nurolahzade.
Changes
-------
Clean up tests.
Repository: aurora
Description
-------
This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
Diffs (updated)
-----
src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
Diff: https://reviews.apache.org/r/56361/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 56361: Add additional tests for the conversion of
TaskStatus.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56361/#review164453
-----------------------------------------------------------
Master (cd4df56) is red with this patch.
./build-support/jenkins/build.sh
:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38: Note: Wrote forwarder org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder
@Forward(AnnotatedAuroraAdmin.class)
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java:69: Line is longer than 100 characters (found 107). [LineLength]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 2 mins 25.023 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 7, 2017, 2:15 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56361/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:15 a.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This adds additional testing for the `ProtosConversions` class, ensuring there is the correct conversion between `SlaveID` and `AgentID`.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java 86e065c62cf2bc7ee173a377efa7b57b41918e40
>
> Diff: https://reviews.apache.org/r/56361/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>