[jira] [Commented] (OPENNLP-1264) Trivial fixes to enable building on, gasp, Windows

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514098#comment-17514098 ] 

ASF GitHub Bot commented on OPENNLP-1264:
-----------------------------------------

jzonthemtn commented on pull request #353:
URL: https://github.com/apache/opennlp/pull/353#issuecomment-1081879805


   I believe these issues have since been resolved for building on Windows. This branch fails the 4 BRAT tests mentioned in [OPENNLP-1358](https://issues.apache.org/jira/browse/OPENNLP-1358) (built from the current master), so it seems the issues targeted in this pull request have been addressed.
   
   I am going to close this pull request and the associated [JIRA task](https://issues.apache.org/jira/browse/OPENNLP-1264) but please feel free to reopen the PR/task if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Trivial fixes to enable building on, gasp, Windows
> --------------------------------------------------
>
>                 Key: OPENNLP-1264
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1264
>             Project: OpenNLP
>          Issue Type: Task
>            Reporter: Tim Allison
>            Assignee: Tim Allison
>            Priority: Trivial
>             Fix For: 1.9.2
>
>
> I had to change 3 things to get a clean build on Windows...I'm not sure the solutions are the most elegant, and these may be user error
> 1) I had to turn off (fail on error) in style checking because of a problem w new lines. On nearly every file, I got this failure.
> {noformat}
> [ERROR] src\test\java\opennlp\tools\util\VersionTest.java:[0] (misc) NewlineAtEndOfFile: File does not end with a newline.
> [WARNING] checkstyle:check violations detected but failOnViolation set to false
> {noformat}
> 2) {{LanguageDetectorEvaluatorTest#processSample}} fails because '\n' are expected, but Windows, of course, writes '\r\n' with {{println}}
> 3) I intentionally have a space in the directory structure to my IdeaProjects directory, which can cause problems on Windows when finding paths.  There are two areas where this happens.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)