You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/08 18:02:30 UTC
[GitHub] [kafka] prat0318 opened a new pull request #10083: MINOR: Remove check for comparision of 3rd IP of kafka.apache.org
prat0318 opened a new pull request #10083:
URL: https://github.com/apache/kafka/pull/10083
kafka.apache.org IP resolution count keeps on varying between 2 and 3, but this should not affect the tests. Removing the test condition which depends on the fact that kafka.apache.org will resolve to 3 different IPs.
As of now, kafka.apache.org is resolving to 2 IPs:
```
$ dig kafka.apache.org
kafka.apache.org. 42 IN A 95.216.26.30
kafka.apache.org. 42 IN A 207.244.88.140
```
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10083: MINOR: Remove check for comparision of 3rd IP of kafka.apache.org
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10083:
URL: https://github.com/apache/kafka/pull/10083#discussion_r572542393
##########
File path: clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
##########
@@ -310,9 +310,6 @@ public void testMultipleIPsWithUseAll() throws UnknownHostException {
connectionStates.connecting(nodeId1, time.milliseconds(), hostTwoIps, ClientDnsLookup.USE_ALL_DNS_IPS);
InetAddress addr2 = connectionStates.currentAddress(nodeId1);
Review comment:
Relying on "specify" number of IPs is still not stable for this tests (for example, the number of resolved IPs becomes 1). It seems to me this test should check whether the number used addresses (after building many connections) is equal to number of resolved addresses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org