[GitHub] [cordova-plugin-inappbrowser] brodybits commented on a change in pull request #584: feat: Add compile-time decision for disabling UIWebView

[GitBox <gi...@apache.org>]

brodybits commented on a change in pull request #584: feat: Add compile-time decision for disabling UIWebView
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#discussion_r362632337
 
 

 ##########
 File path: src/ios/CDVInAppBrowser.m
 ##########
 @@ -49,86 +51,122 @@ - (void)open:(CDVInvokedUrlCommand*)command
         return;
     }
     self.usewkwebview = browserOptions.usewkwebview;
-    if(self.usewkwebview){
-        [[CDVWKInAppBrowser getInstance] open:command];
-    }else{
-        [[CDVUIInAppBrowser getInstance] open:command];
-    }
+    #if WK_WEB_VIEW_ONLY
 
 Review comment:
   I personally find the number of these conditional blocks to be quite a bit ugly. I suspect there should be some clean way to abstract out `[CDVWKInAppBrowser getInstance]` vs `[CDVUIInAppBrowser getInstance]`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org