[GitHub] [superset] michael-s-molina commented on a change in pull request #17063: fix: Owners selection in dataset edit UX

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #17063:
URL: https://github.com/apache/superset/pull/17063#discussion_r727411306



##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -374,6 +374,40 @@ const defaultProps = {
   onChange: () => {},
 };
 
+function OwnersSelector({ datasource, onChange }) {
+  const selectedOwners = datasource.owners.map(owner => ({
+    value: owner.id,
+    label: `${owner.first_name} ${owner.last_name}`,
+  }));
+  const loadOptions = useMemo(() => (search = '', page, pageSize) => {
+    const query = rison.encode({ filter: search, page, page_size: pageSize });
+    return SupersetClient.get({
+      endpoint: `/api/v1/chart/related/owners?q=${query}`,
+    }).then(response => ({
+      data: response.json.result.map(item => ({
+        value: item.value,
+        label: item.text,
+      })),
+      totalCount: response.json.count,
+    }));
+  });

Review comment:
       > I believe if you don't pass any dependencies to useMemo, it will still recalculate on every rerender. 
   
   You're correct. If no array is provided, a new value will be computed on every render. In this case, we are passing a function to the `options` prop of the Select and this prop is used by `useEffect` hooks which means we don't want to recompute it unless the dependencies change. We could use a `useCallback` here but we also don't want to execute the function if it receives the same parameters. That's why we generally use `useMemo` with a dependency array (sometimes empty, sometimes not).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org