You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/30 06:40:31 UTC
[GitHub] [flink-kubernetes-operator] MaksimAniskov opened a new pull request, #286: Fix helm lint invalid Yaml document separator
MaksimAniskov opened a new pull request, #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286
Fixes FLINK-28300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286#issuecomment-1176375567
@morhidi will fix the typo and merge tomorrow, thanks for the ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286#issuecomment-1175868378
@mbalassi can we fix and merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
morhidi commented on code in PR #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286#discussion_r911120987
##########
helm/flink-kubernetes-operator/templates/serviceaccount.yaml:
##########
@@ -17,7 +17,7 @@
################################################################################
---
-{{- if .Values.operatorServiceAccount.create -}}
+{{if .Values.operatorServiceAccount.create }}
Review Comment:
https://helm.sh/docs/chart_template_guide/control_structures/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #286: Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286#issuecomment-1170843100
Thank you @MaksimAniskov , next time when you open a PR please tag both the PR and the commit with the jira like : `[FLINK-XXXX] My Commit/PR message` this way it's easier for reviewers.
you can find details about the process for more complex changes here: https://flink.apache.org/contributing/contribute-code.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
morhidi commented on code in PR #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286#discussion_r911120421
##########
helm/flink-kubernetes-operator/templates/serviceaccount.yaml:
##########
@@ -17,7 +17,7 @@
################################################################################
---
-{{- if .Values.operatorServiceAccount.create -}}
+{{if .Values.operatorServiceAccount.create }}
Review Comment:
I'd also prefer to keep it `{{- if .Values.operatorServiceAccount.create }}` just to be consistent with the rest of the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #286:
URL: https://github.com/apache/flink-kubernetes-operator/pull/286#discussion_r911094153
##########
helm/flink-kubernetes-operator/templates/serviceaccount.yaml:
##########
@@ -17,7 +17,7 @@
################################################################################
---
-{{- if .Values.operatorServiceAccount.create -}}
+{{if .Values.operatorServiceAccount.create }}
Review Comment:
Shouldn't there be a ` ` space before after `{{` ?
##########
helm/flink-kubernetes-operator/templates/serviceaccount.yaml:
##########
@@ -17,7 +17,7 @@
################################################################################
---
-{{- if .Values.operatorServiceAccount.create -}}
+{{if .Values.operatorServiceAccount.create }}
Review Comment:
Shouldn't there be a ` ` space after `{{` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] asfgit closed pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #286: [FLINK-28300] Fix helm lint invalid Yaml document separator
URL: https://github.com/apache/flink-kubernetes-operator/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org