You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/25 03:15:47 UTC

[GitHub] [spark] sethhorrigan edited a comment on issue #26152: [SPARK-27812][K8S][2.4] Bump K8S client version to 4.6.1

sethhorrigan edited a comment on issue #26152: [SPARK-27812][K8S][2.4] Bump K8S client version to 4.6.1
URL: https://github.com/apache/spark/pull/26152#issuecomment-546183144
 
 
   @dongjoon-hyun in the commit referenced above (https://github.com/sethhorrigan/spark/commit/8f96a5ea3d078a205ceb5924bf7aa2af04e6ced1), you can see what I mean `Is it possible to apply this as a patch to 2.4.0`; I forked the Spark repo and applied the changes to the code as of `v2.4.0` as I said, then built the Spark image and tried to start it.
   
   I am aware that `v2.4.5` will be the next release, but your comments on https://github.com/apache/spark/pull/25641 suggest that will likely not be available until January 2020, so if we are going to have to build the Spark image from source until then, it makes as much sense to me to try to patch the code we have been using (`v2.4.0`) as patching another version (`v2.4.4`) and trying to get that working or trying to build from the current `build-2.4` that will have other flaws that will need to be worked out before `v2.4.5` is ready for release.
   
   @srowen the tag `v2.4.0` and `v2.4.0-rc5` both refer to same commit, which I believe was the release `v2.4.0`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org