You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yew1eb <gi...@git.apache.org> on 2018/04/22 08:06:21 UTC

[GitHub] flink pull request #5891: [FLINK-9088][nifi-connector][build] Bump nifi-site...

GitHub user yew1eb opened a pull request:

    https://github.com/apache/flink/pull/5891

    [FLINK-9088][nifi-connector][build] Bump nifi-site-to-site-client to 1.6.0

    ## What is the purpose of the change
    
    *Currently dependency of nifi-site-to-site-client is 0.6.1
    We should upgrade to 1.6.0*
    
    
    ## Brief change log
    
      - *Upgrade `nifi-site-to-site-client` from 0.6.1 to 1.6.0*
    
    ## Verifying this change
    
    Running a nifi cluster in docker: `docker run -d -p 8080:8080  --name=local_nifi   apache/nifi:1.6.0`,
    Successfully run `NiFiSinkTopologyExample` and `NiFiSourceTopologyExample`.
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (**yes** / no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yew1eb/flink FLINK-9088

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5891
    
----
commit 317d9326692e33d5ad6d5f8914e15801144b223c
Author: zhouhai02 <zh...@...>
Date:   2018-04-22T07:55:51Z

    [FLINK-9088][build] Bump nifi-site-to-site-client to 1.6.0

----


---

[GitHub] flink issue #5891: [FLINK-9088][nifi-connector][build] Bump nifi-site-to-sit...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5891
  
    All new dependencies are okay with the Apache License (not for shading, though!)
    
    Because nothing gets shaded here and we left dependency management to the user, this upgrade is okay.
    
    Merging this...


---

[GitHub] flink issue #5891: [FLINK-9088][nifi-connector][build] Bump nifi-site-to-sit...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5891
  
    To get such dependency upgrade PRs merged, it is useful to always add the relevant parts of the dependency tree after the update:
    
    Old:
    ```
    [INFO] org.apache.flink:flink-connector-nifi_2.11:jar:1.6-SNAPSHOT
    [INFO] +- org.apache.nifi:nifi-site-to-site-client:jar:0.6.1:compile
    [INFO] |  +- org.apache.nifi:nifi-api:jar:0.6.1:compile
    [INFO] |  +- org.apache.nifi:nifi-utils:jar:0.6.1:compile
    [INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
    [INFO] |  |  \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
    [INFO] |  \- org.apache.nifi:nifi-client-dto:jar:0.6.1:compile
    [INFO] |     \- com.wordnik:swagger-annotations:jar:1.5.3-M1:compile
    ```
    
    New:
    ```
    [INFO] +- org.apache.nifi:nifi-site-to-site-client:jar:1.6.0:compile
    [INFO] |  +- org.apache.nifi:nifi-api:jar:1.6.0:compile
    [INFO] |  +- org.apache.nifi:nifi-framework-api:jar:1.6.0:compile
    [INFO] |  +- org.apache.nifi:nifi-utils:jar:1.6.0:compile
    [INFO] |  +- org.apache.nifi:nifi-security-utils:jar:1.6.0:compile
    [INFO] |  |  +- commons-codec:commons-codec:jar:1.10:compile
    [INFO] |  |  +- org.bouncycastle:bcprov-jdk15on:jar:1.59:compile
    [INFO] |  |  +- org.bouncycastle:bcpkix-jdk15on:jar:1.59:compile
    [INFO] |  |  \- org.apache.nifi:nifi-properties:jar:1.6.0:compile
    [INFO] |  +- org.apache.commons:commons-lang3:jar:3.3.2:compile
    [INFO] |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.4:compile
    [INFO] |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.0:compile
    [INFO] |  |  \- com.fasterxml.jackson.core:jackson-core:jar:2.9.4:compile
    [INFO] |  +- org.apache.nifi:nifi-client-dto:jar:1.6.0:compile
    [INFO] |  |  +- io.swagger:swagger-annotations:jar:1.5.16:compile
    [INFO] |  |  \- org.apache.nifi.registry:nifi-registry-data-model:jar:0.1.0:compile
    [INFO] |  |     +- javax.validation:validation-api:jar:2.0.0.Final:compile
    [INFO] |  |     \- javax.ws.rs:javax.ws.rs-api:jar:2.1:compile
    [INFO] |  +- org.apache.httpcomponents:httpclient:jar:4.5.3:compile
    [INFO] |  |  +- org.apache.httpcomponents:httpcore:jar:4.4.6:compile
    [INFO] |  |  \- commons-logging:commons-logging:jar:1.1.3:compile
    [INFO] |  \- org.apache.httpcomponents:httpasyncclient:jar:4.1.3:compile
    [INFO] |     \- org.apache.httpcomponents:httpcore-nio:jar:4.4.6:compile
    ```


---

[GitHub] flink pull request #5891: [FLINK-9088][nifi-connector][build] Bump nifi-site...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5891


---