You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/05/01 11:47:41 UTC
[PR] Add dateInterval validation and error handling [airflow]
guan404ming opened a new pull request, #50072:
URL: https://github.com/apache/airflow/pull/50072
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Related Issue
#49652
cc: @bbovenzi
## Why
It is not straightforward to have min/max when input dateInterval
## How
- loosen restrict to only prevent user enter future date
- use field error to handle validation and error message
- not show inline message when there is field error message
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dateInterval validation and error handling [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #50072:
URL: https://github.com/apache/airflow/pull/50072#discussion_r2070205100
##########
airflow-core/src/airflow/ui/src/components/DagActions/RunBackfillForm.tsx:
##########
@@ -158,36 +160,27 @@ const RunBackfillForm = ({ dag, onClose }: RunBackfillFormProps) => {
control={control}
name="from_date"
render={({ field }) => (
- <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid} required>
<Field.Label>From</Field.Label>
- <DateTimeInput
- {...field}
- max={dataIntervalEnd || today}
- onBlur={resetDateError}
- size="sm"
- />
+ <DateTimeInput {...field} max={today} onBlur={resetDateError} size="sm" />
+ <Field.ErrorText>Start Date must be before the End Date</Field.ErrorText>
</Field.Root>
)}
/>
<Controller
control={control}
name="to_date"
render={({ field }) => (
- <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid} required>
<Field.Label>To</Field.Label>
- <DateTimeInput
- {...field}
- max={today}
- min={dataIntervalStart || undefined}
- onBlur={resetDateError}
- size="sm"
- />
+ <DateTimeInput {...field} max={today} onBlur={resetDateError} size="sm" />
+ <Field.ErrorText>Start Date must be before the End Date</Field.ErrorText>
Review Comment:
Does it make sense to display the same error on both fields? Would it not be nicer to display it only once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dateInterval validation and error handling [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #50072:
URL: https://github.com/apache/airflow/pull/50072#discussion_r2070219717
##########
airflow-core/src/airflow/ui/src/components/DagActions/RunBackfillForm.tsx:
##########
@@ -158,36 +160,27 @@ const RunBackfillForm = ({ dag, onClose }: RunBackfillFormProps) => {
control={control}
name="from_date"
render={({ field }) => (
- <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid} required>
<Field.Label>From</Field.Label>
- <DateTimeInput
- {...field}
- max={dataIntervalEnd || today}
- onBlur={resetDateError}
- size="sm"
- />
+ <DateTimeInput {...field} max={today} onBlur={resetDateError} size="sm" />
+ <Field.ErrorText>Start Date must be before the End Date</Field.ErrorText>
</Field.Root>
)}
/>
<Controller
control={control}
name="to_date"
render={({ field }) => (
- <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid} required>
<Field.Label>To</Field.Label>
- <DateTimeInput
- {...field}
- max={today}
- min={dataIntervalStart || undefined}
- onBlur={resetDateError}
- size="sm"
- />
+ <DateTimeInput {...field} max={today} onBlur={resetDateError} size="sm" />
+ <Field.ErrorText>Start Date must be before the End Date</Field.ErrorText>
Review Comment:
Removed, thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dateInterval validation and error handling [airflow]
Posted by "collinmcnulty (via GitHub)" <gi...@apache.org>.
collinmcnulty commented on code in PR #50072:
URL: https://github.com/apache/airflow/pull/50072#discussion_r2070213785
##########
airflow-core/src/airflow/ui/src/components/DagActions/RunBackfillForm.tsx:
##########
@@ -158,36 +160,27 @@ const RunBackfillForm = ({ dag, onClose }: RunBackfillFormProps) => {
control={control}
name="from_date"
render={({ field }) => (
- <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid} required>
<Field.Label>From</Field.Label>
- <DateTimeInput
- {...field}
- max={dataIntervalEnd || today}
- onBlur={resetDateError}
- size="sm"
- />
+ <DateTimeInput {...field} max={today} onBlur={resetDateError} size="sm" />
+ <Field.ErrorText>Start Date must be before the End Date</Field.ErrorText>
</Field.Root>
)}
/>
<Controller
control={control}
name="to_date"
render={({ field }) => (
- <Field.Root invalid={Boolean(errors.date)}>
+ <Field.Root invalid={Boolean(errors.date) || dataIntervalInvalid} required>
<Field.Label>To</Field.Label>
- <DateTimeInput
- {...field}
- max={today}
- min={dataIntervalStart || undefined}
- onBlur={resetDateError}
- size="sm"
- />
+ <DateTimeInput {...field} max={today} onBlur={resetDateError} size="sm" />
+ <Field.ErrorText>Start Date must be before the End Date</Field.ErrorText>
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dateInterval validation and error handling [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #50072:
URL: https://github.com/apache/airflow/pull/50072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org