You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/01 11:11:43 UTC
[GitHub] [pulsar] gaoran10 opened a new pull request #11879: [Test] Fix managed cursor metrics test
gaoran10 opened a new pull request #11879:
URL: https://github.com/apache/pulsar/pull/11879
### Motivation
The two test methods in class `ManagedCursorMetricsTest` will affect each other.
### Modifications
Call the setup method before the test method and call the cleanup method after the test method.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] doc-required
(If you need help on updating docs, create a doc issue)
- [x] no-need-doc
(Please explain why)
- [ ] doc
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11879: [Test] Fix managed cursor metrics test
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11879:
URL: https://github.com/apache/pulsar/pull/11879#discussion_r700154282
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java
##########
@@ -37,13 +37,13 @@
@Test(groups = "quarantine")
Review comment:
Ok, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #11879: [Test] Fix managed cursor metrics test
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #11879:
URL: https://github.com/apache/pulsar/pull/11879#discussion_r700153431
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java
##########
@@ -37,13 +37,13 @@
@Test(groups = "quarantine")
Review comment:
if the test is no more flaky, please replace "quarantive" with "broker" group to make it run along with the other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #11879: [Test] Fix managed cursor metrics test
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11879:
URL: https://github.com/apache/pulsar/pull/11879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org