You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2023/01/12 19:46:37 UTC

[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9290: improve cmake support

cmcfarlen commented on code in PR #9290:
URL: https://github.com/apache/trafficserver/pull/9290#discussion_r1068570603


##########
lib/yamlcpp/CMakeLists.txt:
##########
@@ -93,7 +93,7 @@ endif()
 
 target_compile_options(yaml-cpp
   PRIVATE
-    $<${not-msvc}:-Wall -Wextra -Wshadow -Weffc++ -Wno-long-long>

Review Comment:
   That's ok.  yamlcpp has this flag but then has lots of shadowed variables.  Its just really noisy so I removed it so I could see other issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org