You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/05/27 15:06:06 UTC
[GitHub] [incubator-linkis] jackxu2011 opened a new pull request, #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
jackxu2011 opened a new pull request, #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186
### What is the purpose of the change
fix #1964 and add hadoop-3.3, spark-3.2 , hive-3.1 and scala-2.12 profile
### Brief change log
1. add hadoop-3.3, spark-3.2 , hive-3.1 and scala-2.12 profile
2. unify hadoop, spark, hive version to parent pom
3. unify mysql version to 8.0.16
4. unify maven-deploy-plugin to 3.0.0-M1
5. unify maven-assembly-plugin to 3.2.0
6. unify maven.compiler-plugin to 3.8.1
7. upgrade scala-maven-plugin to 4.3.2
8. upgrade spotless-maven-plugin to 2.22.5 and fix the code format
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- Anything that affects deployment: (no)
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] legendtkl commented on pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#issuecomment-1141577584
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884943551
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
> the refactor logic looks more confused than before, why do this refactor?
当时是改插件的时候，由IDE提示， 只是模式加个大括号，编码理规范一点。也没有多看仔细。目前看其实想表达的是如果属性存在，从属性中读，重新修改了一下代码。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884943551
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
> the refactor logic looks more confused than before, why do this refactor?
当时是改插件的时候，由IDE提示。也没有多看仔细。目前看其实想表达的是如果属性存在，从属性中读，重新修改了一下代码。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#issuecomment-1139709955
1. 以后修改引擎版本，hadoop, spark, hive的引擎版本就都在parent的pom文件中
2. 可以用命令 mvn clean install -Pspark-3.2 -Phive-3.1 -Phadoop-3.3 打包， 但是在打包前要改一个spark3.2的代码兼容问题，在profile中有说明
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong closed pull request #2186: [WIP]feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
peacewong closed pull request #2186: [WIP]feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
URL: https://github.com/apache/incubator-linkis/pull/2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] legendtkl commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
legendtkl commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884932711
##########
linkis-engineconn-plugins/engineconn-plugins/hive/pom.xml:
##########
@@ -208,89 +204,6 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
- <version>${hadoop.version}</version>
- <exclusions>
Review Comment:
why remove the exclusions
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
the refactor logic looks more confused than before, why do this refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884943551
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
> the refactor logic looks more confused than before, why do this refactor?
减少代码复杂度， 其实可读性应该没有降低多少。如果觉得不行，可以改回来。其实还可以再改的直观一点，就是这次主要是改插件，这个是顺手改的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884943551
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
> the refactor logic looks more confused than before, why do this refactor?
减少代码复杂度， 其实可读性应该没有降低多少。如果觉得不行，可以改回来。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#issuecomment-1139720878
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2186?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2186](https://codecov.io/gh/apache/incubator-linkis/pull/2186?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc6ee08) into [dev-1.1.2](https://codecov.io/gh/apache/incubator-linkis/commit/89cc8bd54241d734f1f21f2f410ad345bb7655bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89cc8bd) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev-1.1.2 #2186 +/- ##
===============================================
- Coverage 19.62% 19.57% -0.05%
+ Complexity 843 842 -1
===============================================
Files 383 383
Lines 11819 11820 +1
Branches 1757 1757
===============================================
- Hits 2319 2314 -5
- Misses 9257 9262 +5
- Partials 243 244 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/linkis/common/utils/ByteTimeUtils.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL2NvbW1vbi91dGlscy9CeXRlVGltZVV0aWxzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...g/apache/linkis/common/conf/BDPConfiguration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vY29uZi9CRFBDb25maWd1cmF0aW9uLnNjYWxh) | `25.00% <0.00%> (ø)` | |
| [...ala/org/apache/linkis/common/conf/CommonVars.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vY29uZi9Db21tb25WYXJzLnNjYWxh) | `15.38% <0.00%> (-1.29%)` | :arrow_down: |
| [...inkis/cli/application/LinkisClientApplication.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vTGlua2lzQ2xpZW50QXBwbGljYXRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| [...li/application/interactor/job/LinkisManageJob.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vaW50ZXJhY3Rvci9qb2IvTGlua2lzTWFuYWdlSm9iLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../cli/application/interactor/job/LinkisOnceJob.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vaW50ZXJhY3Rvci9qb2IvTGlua2lzT25jZUpvYi5qYXZh) | `0.00% <ø> (ø)` | |
| [...interactor/job/builder/LinkisManageJobBuilder.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vaW50ZXJhY3Rvci9qb2IvYnVpbGRlci9MaW5raXNNYW5hZ2VKb2JCdWlsZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...n/interactor/job/builder/LinkisOnceJobBuilder.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vaW50ZXJhY3Rvci9qb2IvYnVpbGRlci9MaW5raXNPbmNlSm9iQnVpbGRlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...interactor/job/builder/LinkisSubmitJobBuilder.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vaW50ZXJhY3Rvci9qb2IvYnVpbGRlci9MaW5raXNTdWJtaXRKb2JCdWlsZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...i/application/operator/ujes/LinkisJobOperator.java](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNsaWVudC9saW5raXMtY2xpL2xpbmtpcy1jbGktYXBwbGljYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9jbGkvYXBwbGljYXRpb24vb3BlcmF0b3IvdWplcy9MaW5raXNKb2JPcGVyYXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/incubator-linkis/pull/2186/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2186?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2186?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [89cc8bd...bc6ee08](https://codecov.io/gh/apache/incubator-linkis/pull/2186?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #2186: [WIP]feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
casionone commented on PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#issuecomment-1153399177
As discussed
Major changes require basic engine regression testing. We need to organize a regression test baseline. After verification, there is no problem, and then merge
--------
如我们所讨论的
大的变动，需要进行基本引擎回归测试，我们正在整理一个回归测试基线 验证没问题后， 然后再合并
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884943551
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
> the refactor logic looks more confused than before, why do this refactor?
减少代码复杂度， 其实可读性应该没有降低多少
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884942282
##########
linkis-engineconn-plugins/engineconn-plugins/hive/pom.xml:
##########
@@ -208,89 +204,6 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
- <version>${hadoop.version}</version>
- <exclusions>
Review Comment:
统一在parent中进行排除，不用在每一个模块中进行排除
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#issuecomment-1144318343
can close #91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] legendtkl commented on a diff in pull request #2186: feat: add hadoop3.3, spark3.2, hive3.1, scala2.12 profile and unify some maven plugin
Posted by GitBox <gi...@apache.org>.
legendtkl commented on code in PR #2186:
URL: https://github.com/apache/incubator-linkis/pull/2186#discussion_r884949379
##########
linkis-commons/linkis-common/src/main/scala/org/apache/linkis/common/conf/CommonVars.scala:
##########
@@ -17,14 +17,18 @@
package org.apache.linkis.common.conf
+import java.util.Properties
import scala.collection.JavaConversions._
case class CommonVars[T](key: String, defaultValue: T, value: T, description: String = null) {
val getValue: T = BDPConfiguration.getOption(this).getOrElse(defaultValue)
def getValue(properties: java.util.Map[String, String]): T = {
- if(properties == null || !properties.containsKey(key) || properties.get(key) == null) getValue
- else BDPConfiguration.formatValue(defaultValue, Option(properties.get(key))).get
+ if (!(properties == null || !properties.containsKey(key)) && !(properties.get(key) == null)) {
Review Comment:
I prefer the code before changed. What do you think ? @peacewong @casionone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org