RE: lucene-solr:master: re-enable test, there is nothing wrong with this test, its not a goddamn bad apple. its just great at finding bugs

[Uwe Schindler <uw...@thetaphi.de>]

Thanks Robert!

I did not notice this otherwise I would have complained already!

This test is there to actually findbugs, if it fails we have to take care ASAP and open an issue! We are happy if it fails. 😊

It is not a bug like the Solr ones that fail from time to time because of the broken test setup, e.g.,  with timeouts that depend on CPU speed or similar horrible stuff.

Uwe

-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de

> -----Original Message-----
> From: rmuir@apache.org [mailto:rmuir@apache.org]
> Sent: Sunday, March 4, 2018 2:45 PM
> To: commits@lucene.apache.org
> Subject: lucene-solr:master: re-enable test, there is nothing wrong with this
> test, its not a goddamn bad apple. its just great at finding bugs
> 
> Repository: lucene-solr
> Updated Branches:
>   refs/heads/master 9de4225e9 -> b83d20337
> 
> 
> re-enable test, there is nothing wrong with this test, its not a goddamn bad
> apple. its just great at finding bugs
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucene-
> solr/commit/b83d2033
> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/b83d2033
> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/b83d2033
> 
> Branch: refs/heads/master
> Commit: b83d20337279fcb90dbfddb176635616bec97bb5
> Parents: 9de4225
> Author: Robert Muir <rm...@apache.org>
> Authored: Sun Mar 4 08:44:10 2018 -0500
> Committer: Robert Muir <rm...@apache.org>
> Committed: Sun Mar 4 08:44:10 2018 -0500
> 
> ----------------------------------------------------------------------
>  .../src/test/org/apache/lucene/analysis/core/TestRandomChains.java  | 1 -
>  1 file changed, 1 deletion(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/lucene-
> solr/blob/b83d2033/lucene/analysis/common/src/test/org/apache/lucene/a
> nalysis/core/TestRandomChains.java
> ----------------------------------------------------------------------
> diff --git
> a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestR
> andomChains.java
> b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestR
> andomChains.java
> index 3ef50fb..406addf 100644
> ---
> a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestR
> andomChains.java
> +++
> b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestR
> andomChains.java
> @@ -843,7 +843,6 @@ public class TestRandomChains extends
> BaseTokenStreamTestCase {
>      String toString;
>    }
> 
> -  @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
>    public void testRandomChains() throws Throwable {
>      int numIterations = TEST_NIGHTLY ? atLeast(20) : 3;
>      Random random = random();


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org