You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by dhutchis <gi...@git.apache.org> on 2015/08/24 03:31:57 UTC
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
GitHub user dhutchis opened a pull request:
https://github.com/apache/accumulo/pull/44
ACCUMULO-3971 Better doc for tracing
This adds an example of how to configure another SpanReceiver for tracing by the Accumulo server and by the client. Also documents the format of the trace table and some utilities.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhutchis/accumulo ACCUMULO-3971
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit cf5ef46f3a450c50aa804445d4a82fbabb18dacd
Author: Dylan Hutchison <dh...@mit.edu>
Date: 2015-08-23T23:50:24Z
ACCUMULO-3971 Add more tracing doc to user manual
commit 16db78737a2d4438f34eb72a8c7f0e785f17a280
Author: Dylan Hutchison <dh...@mit.edu>
Date: 2015-08-24T01:25:30Z
ACCUMULO-3971 Add trace table format and utilities to manual
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by billierinaldi <gi...@git.apache.org>.
Github user billierinaldi commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-134574703
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by billierinaldi <gi...@git.apache.org>.
Github user billierinaldi commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-134325576
This looks great. Thanks, Dylan! I have two suggestions. One is about the sentence, "Span entries record full span information, whereas index and start time entries provide indexing into span information useful for quickly finding spans by type or start time." Actually both the span and start time entries have the full span information, while only the index entries provide indexing.
The other suggestion is to mention other configuration properties that would need to be set for the zipkin span receiver in accumulo-site.xml and in the client configuration, such as:
```
<property>
<name>trace.span.receiver.zipkin.collector-hostname</name>
<value>localhost</value>
</property>
<property>
<name>trace.span.receiver.zipkin.collector-port</name>
<value>9410</value>
</property>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by dhutchis <gi...@git.apache.org>.
Github user dhutchis commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-134330086
Thanks for spotting that sentence Billie, will fix tonight. It's good to
throw in the rest of the Zipkin configuration as well (I was using the
default localhost and port).
On Mon, Aug 24, 2015 at 2:22 PM, billierinaldi <no...@github.com>
wrote:
> This looks great. Thanks, Dylan! I have two suggestions. One is about the
> sentence, "Span entries record full span information, whereas index and
> start time entries provide indexing into span information useful for
> quickly finding spans by type or start time." Actually both the span and
> start time entries have the full span information, while only the index
> entries provide indexing.
>
> The other suggestion is to mention other configuration properties that
> would need to be set for the zipkin span receiver in accumulo-site.xml and
> in the client configuration, such as:
>
> <property>
> <name>trace.span.receiver.zipkin.collector-hostname</name>
> <value>localhost</value>
> </property>
> <property>
> <name>trace.span.receiver.zipkin.collector-port</name>
> <value>9410</value>
> </property>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/accumulo/pull/44#issuecomment-134325576>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-134317691
This is all really great! +1 from me, would be good to hear from @billierinaldi and/or @ericnewton if they have some time.
The unrelated formatting change will be squashed by me -- I noticed I goofed that up over the weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by dhutchis <gi...@git.apache.org>.
Github user dhutchis commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-134410576
Okay, this is set. On a slightly related note, I see that Zipkin supports HBase, Cassandra and Anorm connections as backing stores for traces. I wonder how much work it would take to get Zipkin's interface and/or trace-aggregating-statistics to use Accumulo as a backing store.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/44#issuecomment-135622445
> I wonder how much work it would take to get Zipkin's interface and/or trace-aggregating-statistics to use Accumulo as a backing store.
Not an excessive amount of work: https://github.com/jaredwinick/accumulo-trace-zipkin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-3971 Better doc for tracing
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---