You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Lukas Theussl (JIRA)" <ji...@codehaus.org> on 2006/06/22 23:08:40 UTC

[jira] Created: (MPECLIPSE-119) plugin:test broken in 1.11

plugin:test broken in 1.11
--------------------------

         Key: MPECLIPSE-119
         URL: http://jira.codehaus.org/browse/MPECLIPSE-119
     Project: maven-eclipse-plugin
        Type: Bug

    Versions: 1.11    
 Environment: m11b3
    Reporter: Lukas Theussl
 Assigned to: Stephane Nicoll 
     Fix For: 1.11.1


The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_69023 ] 

Arnaud Heritier commented on MPECLIPSE-119:
-------------------------------------------

This is because the maven.jar dependency is now overriden in all plugins (in plugins-parent) which was not the case before (only defined in some plugins)

> plugin:test broken in 1.11
> --------------------------
>
>          Key: MPECLIPSE-119
>          URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>      Project: maven-eclipse-plugin
>         Type: Bug

>     Versions: 1.11
>  Environment: m11b3
>     Reporter: Lukas Theussl
>     Assignee: Stephane Nicoll
>      Fix For: 1.11.1

>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=all ]

Stephane Nicoll closed MPECLIPSE-119.
-------------------------------------

    Resolution: Fixed

This is fixed, execpt the cactus dependency thingy.

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_72805 ] 
            
Stephane Nicoll commented on MPECLIPSE-119:
-------------------------------------------

The error is here

{code:xml}
<!-- don't add duplicate directories -->
          <j:if
            test="${resourceDirectoryFile.exists() and !resourceDirectory.equals(srcDir) and (!resourceDirectory.equals(testSrcDir) or !unitTestSourcesPresent)}">
            <classpathentry kind="src" path="${resourceDirectory}" including="${includingAsString}"
              excluding="${excludingAsString}" />
          </j:if>
{code}

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_72797 ] 
            
Stephane Nicoll commented on MPECLIPSE-119:
-------------------------------------------

Lukas, can you help? 

I've "fixed" the cactus dependency problem but we need to investigate. The current cactus dependency is 13-1.6.1 but the cactus plugin expected 13-1.7. I tried to retrieve the version from the plugin to automate this but it does not work so I changed it this way

{code:xml}
<echo>Warning, expecting cactus version 13.1-7 from current cactus plugin</echo>
<x:set var="countCactus" select="count($classpathDoc/classpath/classpathentry[contains(@path,'MAVEN_REPO/cactus/jars/cactus-13-1.7.jar')])"/>
{code}


Further on, the plugin breaks and I think we have a bug

{code:xml}
  <classpathentry excluding="" including="" kind="src" path="src/test">
  </classpathentry>
  <classpathentry output="target/test-classes" kind="src" path="src/test">
  </classpathentry>
{code}

To me, this entry is duplicated right?

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_72795 ] 
            
Stephane Nicoll commented on MPECLIPSE-119:
-------------------------------------------

Ouh ouh ; Classpath.jelly requests the cactus dependency of the maven plugin so it's really nasty to test on that (if you have another cactus plugin, it might break).

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_72809 ] 
            
Stephane Nicoll commented on MPECLIPSE-119:
-------------------------------------------

Ok found it, cactus was reseting the testSrcDir to a wrong value.

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=all ]

Lukas Theussl reopened MPECLIPSE-119:
-------------------------------------

             
It's not fixed for me, plugin:test still fails for the same reason that I stated above. (I never noticed the cactus problem as I never used cactus and don't have it installed.) I can fix it easily but I don't know what is actually the expected entry in .classpath, is it

 <classpathentry kind="lib" path="MAVEN_REPO/maven/jars/maven.jar"></classpathentry>

or is it

 <classpathentry kind="lib" path="${MAVEN_HOME}/lib/maven.jar"></classpathentry>
?

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=all ]

Lukas Theussl closed MPECLIPSE-119.
-----------------------------------

    Resolution: Fixed

Fixed. We now check for both classpathentries, at least one of them has to be present.

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_72808 ] 
            
Stephane Nicoll commented on MPECLIPSE-119:
-------------------------------------------

mmm weird. I think the jelly test is not working as expected:

{noformat}
    [echo] resourceDirectoryFile.exists(): true
    [echo] resourceDirectory.equals(srcdir): false
    [echo] resourceDirectory.equals(testSrcDir): false
    [echo] unitTestSourcesPresent: true
    [echo] Will add entry for src/test
    [echo] Contains JUnit tests
    [echo] Setting compile of src/test to target/test-classes
{noformat}

should be a 'and' I guess for the last test

> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPECLIPSE-119) plugin:test broken in 1.11

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPECLIPSE-119?page=comments#action_72870 ] 
            
Stephane Nicoll commented on MPECLIPSE-119:
-------------------------------------------

Well. I did not have to change anything for me, it worked in a first place.

Expected entry is 'MAVEN_REPO/maven/jars/maven.jar'



> plugin:test broken in 1.11
> --------------------------
>
>                 Key: MPECLIPSE-119
>                 URL: http://jira.codehaus.org/browse/MPECLIPSE-119
>             Project: maven-eclipse-plugin
>          Issue Type: Bug
>    Affects Versions: 1.11
>         Environment: m11b3
>            Reporter: Lukas Theussl
>         Assigned To: Stephane Nicoll
>             Fix For: 1.11.1
>
>
> The test test-classpath-has-overridden-jar in src/plugin-test/maintest/maven.xml fails. For some reason, the string MAVEN_REPO/maven/jars/maven.jar is replaced by $MAVEN_HOME/lib/maven.jar. If this is intentional, the test should be rewritten.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira