[jira] [Commented] (TINKERPOP-2480) User agent for Gremlin drivers

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642732#comment-17642732 ] 

ASF GitHub Bot commented on TINKERPOP-2480:
-------------------------------------------

cole-bq opened a new pull request, #1883:
URL: https://github.com/apache/tinkerpop/pull/1883

   Progress towards [TINKERPOP-2480](https://issues.apache.org/jira/browse/TINKERPOP-2480)
   
   Adds a user agent to gremlin-javascript which is sent as a request header during the web socket handshake.
   
   User agent follows the form of [Application Name] [GLV Name].[Version] [Language Runtime Version] [OS].[Version] [CPU Architecture]
   
   This behavior is enabled by default but can be disabled by setting the enableUserAgentOnConnect option to false.
   
   Note: There are no tests included as part of this PR. My intention is to add integration tests to ensure that the user agent is being sent correctly once [TINKERPOP-2819](https://issues.apache.org/jira/browse/TINKERPOP-2819) has been merged. The existing javascript glv tests are sufficient to show that this change does not introduce any faults into the driver. I have conducted manual tests to ensure that the changes are currently functioning correctly. My thoughts are that with a potential release approaching, it is worthwhile to have the user agent introduced now, with full validation coming soon.
   
   This PR also adds a configuration section to the JS reference documentation in order to be consistent with the other GLV's. The configuration table is populated based on the JSDoc comments from the Connection, Client, and DriverRemoteConnection constructors.




> User agent for Gremlin drivers
> ------------------------------
>
>                 Key: TINKERPOP-2480
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2480
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver, server
>    Affects Versions: 3.4.8
>            Reporter: Divij Vaidya
>            Priority: Minor
>
> Currently, a server does not distinguish amongst the different types of clients connecting to it. This issue is to add a new feature to add user agent field in the HTTP and WebSocket request header which could be used to identify the specific client from which the request was made.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)