[GitHub] [spark] cloud-fan commented on a change in pull request #27718: [WIP][SPARK-30885][SQL][FOLLOW-UP] Fix a hack in ResolveSessionCatalog.TempViewOrV1Table

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27718: [WIP][SPARK-30885][SQL][FOLLOW-UP] Fix a hack in ResolveSessionCatalog.TempViewOrV1Table
URL: https://github.com/apache/spark/pull/27718#discussion_r384908705
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
 ##########
 @@ -663,14 +663,9 @@ class ResolveSessionCatalog(
   object TempViewOrV1Table {
     def unapply(nameParts: Seq[String]): Option[Seq[String]] = nameParts match {
       case _ if isTempView(nameParts) => Some(nameParts)
-      case SessionCatalogAndTable(_, tbl) =>
-        if (nameParts.head == CatalogManager.SESSION_CATALOG_NAME && tbl.length == 1) {
-          // For name parts like `spark_catalog.t`, we need to fill in the default database so
-          // that the caller side won't treat it as a temp view.
-          Some(Seq(catalogManager.v1SessionCatalog.getCurrentDatabase, tbl.head))
-        } else {
-          Some(tbl)
-        }
+      case Seq(CatalogManager.SESSION_CATALOG_NAME, viewName @ _*) if isTempView(viewName) =>
+        throw new AnalysisException("Temp view name cannot contain catalog name")
 
 Review comment:
   I think we should fail with no such table/database if when see something like `spark_catalog.tempViewName`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org