[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3991: Fix the problem of mem exec, when analytic eval node need to spill to disk with a low mem limit

[GitBox <gi...@apache.org>]

HappenLee commented on a change in pull request #3991:
URL: https://github.com/apache/incubator-doris/pull/3991#discussion_r448740284



##########
File path: be/src/exec/analytic_eval_node.cpp
##########
@@ -710,7 +709,13 @@ Status AnalyticEvalNode::process_child_batch(RuntimeState* state) {
 
     // Transfer resources to _prev_tuple_pool when enough resources have accumulated
     // and the _prev_tuple_pool has already been transfered to an output batch.
-    if (_curr_tuple_pool->total_allocated_bytes() > MAX_TUPLE_POOL_SIZE &&
+
+    // The memory limit of _curr_tuple_pool is set by the fixed value MAX_TUPLE_POOL_SIZE

Review comment:
       ok，i will change the comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org