You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "pch8388 (via GitHub)" <gi...@apache.org> on 2023/07/10 14:02:23 UTC

[GitHub] [kafka] pch8388 opened a new pull request, #13985: MINOR : Changing the invalid domain name of the test code to a meaningful one

pch8388 opened a new pull request, #13985:
URL: https://github.com/apache/kafka/pull/13985

   I want to discuss the topics that were previously discussed in the [PR](https://github.com/apache/kafka/pull/2552).
   In my opinion, using `.invalid` instead of `.local` would be more appropriate.
   The reason is that `.invalid` aligns better with the intended meaning we are using in the tests.
   `.local` is a domain reserved for Multicast DNS usage and does not match the current purpose according to [RFC6762](https://www.rfc-editor.org/rfc/rfc6762.html#section-3).
   [Apple](https://support.apple.com/en-us/HT207511) actually uses the `.local` domain for its intended purpose and provides guidance in that regard.
   Since `.invalid` seems to align with our intended purpose, it would be better to use this domain.
   [RFC6761](https://www.rfc-editor.org/rfc/rfc6761.html#section-6.4)
   [RFC2606](https://datatracker.ietf.org/doc/html/rfc2606#section-2)
   
   Regarding the name collision issue with the `.invalid` domain mentioned in the [comment](https://github.com/apache/kafka/pull/2552#issuecomment-280829672), it is likely a problem with older versions of JDK.
   As seen in the [JDK BUG System](https://bugs.openjdk.org/browse/JDK-8058932), the .invalid domain performs the functionality of an invalid domain correctly.
   
   Therefore, I believe that we should use a domain name that matches the intended meaning.
   I suggest modifying `some.invalid.hostname.foo.bar.local` to `some.invalid`.
   
   ---
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR : Changing the invalid domain name of the test code to a meaningful one [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13985:
URL: https://github.com/apache/kafka/pull/13985#issuecomment-2563280488

   This PR has been closed since it has not had any activity in 120 days. If you feel like this
   was a mistake, or you would like to continue working on it, please feel free to re-open the 
   PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] pch8388 commented on pull request #13985: MINOR : Changing the invalid domain name of the test code to a meaningful one

Posted by "pch8388 (via GitHub)" <gi...@apache.org>.
pch8388 commented on PR #13985:
URL: https://github.com/apache/kafka/pull/13985#issuecomment-1642967561

   @showuon @divijvaidya would you please review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] pch8388 commented on pull request #13985: MINOR : Changing the invalid domain name of the test code to a meaningful one

Posted by "pch8388 (via GitHub)" <gi...@apache.org>.
pch8388 commented on PR #13985:
URL: https://github.com/apache/kafka/pull/13985#issuecomment-1638087710

   @ijuma would you please review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR : Changing the invalid domain name of the test code to a meaningful one [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13985: MINOR : Changing the invalid domain name of the test code to a meaningful one
URL: https://github.com/apache/kafka/pull/13985


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR : Changing the invalid domain name of the test code to a meaningful one [kafka]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13985:
URL: https://github.com/apache/kafka/pull/13985#issuecomment-1767571768

   This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has  merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org