You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by GitBox <gi...@apache.org> on 2021/04/15 19:52:22 UTC
[GitHub] [openoffice] dave2wave opened a new pull request #127: Allow all https(s) Hyperlinks
dave2wave opened a new pull request #127:
URL: https://github.com/apache/openoffice/pull/127
There was some debate on which is best for 4.1.10. Here is the PR should we go this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [GitHub] [openoffice] jimjag commented on pull request #127:
Allow all https(s) Hyperlinks
Posted by Carl Marcum <cm...@apache.org>.
I'm building this PR now. I should have it tested soon.
On 4/16/21 2:02 PM, GitBox wrote:
> jimjag commented on pull request #127:
> URL: https://github.com/apache/openoffice/pull/127#issuecomment-821368755
>
>
> +1
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] jimjag commented on pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
jimjag commented on pull request #127:
URL: https://github.com/apache/openoffice/pull/127#issuecomment-821368755
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] dave2wave commented on pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
dave2wave commented on pull request #127:
URL: https://github.com/apache/openoffice/pull/127#issuecomment-821533514
Well the CVE was about non-http(s) links. I think we are good to go. Especially since no one engaged to reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] cbmarcum commented on pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
cbmarcum commented on pull request #127:
URL: https://github.com/apache/openoffice/pull/127#issuecomment-821576281
I figured so but I thought I should check. I've seen people get surprised by the fall though behavior in a switch case and I didn't check for HTTP before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] dave2wave commented on pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
dave2wave commented on pull request #127:
URL: https://github.com/apache/openoffice/pull/127#issuecomment-821572470
Yes. That was the intent. Maybe in 4.2.0 we discussing forcing http to https as one of our hyperlink security settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] cbmarcum commented on pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
cbmarcum commented on pull request #127:
URL: https://github.com/apache/openoffice/pull/127#issuecomment-821536102
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] cbmarcum commented on pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
cbmarcum commented on pull request #127:
URL: https://github.com/apache/openoffice/pull/127#issuecomment-821538999
Just to be clear this also allows any extension with HTTP also. Just wanted to make sure that was the intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
[GitHub] [openoffice] dave2wave merged pull request #127: Allow all https(s) Hyperlinks
Posted by GitBox <gi...@apache.org>.
dave2wave merged pull request #127:
URL: https://github.com/apache/openoffice/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org