You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "ralf0131 (GitHub)" <gi...@apache.org> on 2019/03/11 02:23:02 UTC

[GitHub] [incubator-dubbo] ralf0131 opened issue #3627: Move org.apache.dubbo.registry.ZKTools to test code

org.apache.dubbo.registry.ZKTools is never used in source code, I suggest to move it to test.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3627 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] JerryChin commented on issue #3627: Move org.apache.dubbo.registry.ZKTools to test code

Posted by "JerryChin (GitHub)" <gi...@apache.org>.

I'm a bit confused, `org.apache.dubbo.registry.ZKTools` has resided in the test directory of `dubbo-registr-api` in `master` branch since its creation, as observed from its version history, am I missing something?

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3627 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3627: Move org.apache.dubbo.registry.ZKTools to test code

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.

You are right, my bad... Maybe it is better add some description to the class.

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/3627 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org