You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/21 12:11:47 UTC

[GitHub] [superset] simchaNielsen opened a new pull request #12655: test: Add test to scoping tree in native filters modal

simchaNielsen opened a new pull request #12655:
URL: https://github.com/apache/superset/pull/12655


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Add test to Scoping tree in native filters modals, includes also tests for FiltersScope functionality
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (1ba688e) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `7.92%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   58.87%   -7.93%     
   ==========================================
     Files        1015      963      -52     
     Lines       49676    47114    -2562     
     Branches     4847     4396     -451     
   ==========================================
   - Hits        33183    27737    -5446     
   - Misses      16371    19377    +3006     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.90% <28.00%> (-0.15%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.39% <ø> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [419 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...1ba688e](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io commented on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   63.43%   -3.37%     
   ==========================================
     Files        1015      486     -529     
     Lines       49676    29969   -19707     
     Branches     4847        0    -4847     
   ==========================================
   - Hits        33183    19010   -14173     
   + Misses      16371    10959    -5412     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.43% <ø> (-0.57%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.20% <0.00%> (-0.77%)` | :arrow_down: |
   | [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
   | ... and [531 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.37%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   63.42%   -3.38%     
   ==========================================
     Files        1015      486     -529     
     Lines       49676    29984   -19692     
     Branches     4847        0    -4847     
   ==========================================
   - Hits        33183    19017   -14166     
   + Misses      16371    10967    -5404     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.42% <ø> (-0.58%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.20% <0.00%> (-0.77%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.85% <0.00%> (-0.45%)` | :arrow_down: |
   | ... and [524 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (1ba688e) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `16.26%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12655       +/-   ##
   ===========================================
   - Coverage   66.79%   50.53%   -16.27%     
   ===========================================
     Files        1015      476      -539     
     Lines       49676    17070    -32606     
     Branches     4847     4396      -451     
   ===========================================
   - Hits        33183     8626    -24557     
   + Misses      16371     8444     -7927     
   + Partials      122        0      -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.53% <28.00%> (-0.52%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [878 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...1ba688e](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro merged pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
villebro merged pull request #12655:
URL: https://github.com/apache/superset/pull/12655


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (1ba688e) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `7.92%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   58.87%   -7.93%     
   ==========================================
     Files        1015      963      -52     
     Lines       49676    47099    -2577     
     Branches     4847     4396     -451     
   ==========================================
   - Hits        33183    27730    -5453     
   - Misses      16371    19369    +2998     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.90% <28.00%> (-0.15%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.40% <ø> (-0.59%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [426 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...1ba688e](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simchaNielsen commented on a change in pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #12655:
URL: https://github.com/apache/superset/pull/12655#discussion_r563250190



##########
File path: superset-frontend/spec/javascripts/dashboard/components/nativeFilters/FilterScope_spec.tsx
##########
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Provider } from 'react-redux';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import { mockStoreWithTabsCombined } from 'spec/fixtures/mockStore';
+import { Form, FormInstance } from 'src/common/components';
+import { NativeFiltersForm } from 'src/dashboard/components/nativeFilters/types';
+import FilterConfigForm from 'src/dashboard/components/nativeFilters/FilterConfigForm';
+
+describe('FilterScope', () => {
+  const save = jest.fn();
+  let form: FormInstance<NativeFiltersForm>;
+  const mockedProps = {
+    filterId: 'DefaultFilterId',
+    restore: jest.fn(),
+    parentFilters: [],
+    save,
+  };
+
+  const MockModal = ({ scope }: { scope: object | undefined }) => {
+    const [newForm] = Form.useForm<NativeFiltersForm>();
+    form = newForm;
+    if (scope) {
+      form.setFieldsValue({
+        filters: {
+          [mockedProps.filterId]: {
+            scope,
+          },
+        },
+      });
+    }
+    return (
+      <Provider store={mockStoreWithTabsCombined}>
+        <Form form={form}>
+          <FilterConfigForm form={form} {...mockedProps} />
+        </Form>
+      </Provider>
+    );
+  };
+
+  const getWrapper = (scope?: object) => {
+    render(<MockModal scope={scope} />);
+  };
+
+  const getTreeSwitcher = (order = 0) =>
+    document.querySelectorAll('.ant-tree-switcher')[order];

Review comment:
       I didn't find way to add `data-test` attribute to the Tree switcher, it looks like Ant did propose such api




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (1ba688e) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `15.89%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12655       +/-   ##
   ===========================================
   - Coverage   66.79%   50.90%   -15.90%     
   ===========================================
     Files        1015      476      -539     
     Lines       49676    17070    -32606     
     Branches     4847     4396      -451     
   ===========================================
   - Hits        33183     8690    -24493     
   + Misses      16371     8380     -7991     
   + Partials      122        0      -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.90% <28.00%> (-0.15%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [878 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...1ba688e](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `7.88%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   58.90%   -7.89%     
   ==========================================
     Files        1015      961      -54     
     Lines       49676    46994    -2682     
     Branches     4847     4379     -468     
   ==========================================
   - Hits        33183    27684    -5499     
   - Misses      16371    19310    +2939     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.95% <28.00%> (-0.10%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.42% <ø> (-0.58%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `68.00% <ø> (-14.15%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `50.85% <ø> (-12.18%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [402 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a change in pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12655:
URL: https://github.com/apache/superset/pull/12655#discussion_r564469086



##########
File path: superset-frontend/spec/javascripts/dashboard/components/nativeFilters/FilterScope_spec.tsx
##########
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Provider } from 'react-redux';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import { mockStoreWithTabsCombined } from 'spec/fixtures/mockStore';
+import { Form, FormInstance } from 'src/common/components';
+import { NativeFiltersForm } from 'src/dashboard/components/nativeFilters/types';
+import FilterConfigForm from 'src/dashboard/components/nativeFilters/FilterConfigForm';
+
+describe('FilterScope', () => {
+  const save = jest.fn();
+  let form: FormInstance<NativeFiltersForm>;
+  const mockedProps = {
+    filterId: 'DefaultFilterId',
+    restore: jest.fn(),
+    parentFilters: [],
+    save,
+  };
+
+  const MockModal = ({ scope }: { scope: object | undefined }) => {
+    const [newForm] = Form.useForm<NativeFiltersForm>();
+    form = newForm;
+    if (scope) {
+      form.setFieldsValue({
+        filters: {
+          [mockedProps.filterId]: {
+            scope,
+          },
+        },
+      });
+    }
+    return (
+      <Provider store={mockStoreWithTabsCombined}>
+        <Form form={form}>
+          <FilterConfigForm form={form} {...mockedProps} />
+        </Form>
+      </Provider>
+    );
+  };
+
+  const getWrapper = (scope?: object) => {
+    render(<MockModal scope={scope} />);
+  };
+
+  const getTreeSwitcher = (order = 0) =>
+    document.querySelectorAll('.ant-tree-switcher')[order];

Review comment:
       Oh, you're right, this appears to only be supported on certain AntD components currently.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `8.02%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   58.77%   -8.03%     
   ==========================================
     Files        1015      961      -54     
     Lines       49676    46994    -2682     
     Branches     4847     4379     -468     
   ==========================================
   - Hits        33183    27620    -5563     
   - Misses      16371    19374    +3003     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `50.57% <28.00%> (-0.48%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.42% <ø> (-0.58%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `68.00% <ø> (-14.15%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `50.85% <ø> (-12.18%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [402 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (1ba688e) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `18.79%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12655       +/-   ##
   ===========================================
   - Coverage   66.79%   48.00%   -18.80%     
   ===========================================
     Files        1015      476      -539     
     Lines       49676    17070    -32606     
     Branches     4847     4396      -451     
   ===========================================
   - Hits        33183     8194    -24989     
   + Misses      16371     8876     -7495     
   + Partials      122        0      -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `48.00% <28.00%> (-3.05%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [889 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...1ba688e](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io commented on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `3.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   63.43%   -3.37%     
   ==========================================
     Files        1015      486     -529     
     Lines       49676    29969   -19707     
     Branches     4847        0    -4847     
   ==========================================
   - Hits        33183    19010   -14173     
   + Misses      16371    10959    -5412     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.43% <ø> (-0.57%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-11.48%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.20% <0.00%> (-0.77%)` | :arrow_down: |
   | [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
   | ... and [531 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `9.58%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12655      +/-   ##
   ==========================================
   - Coverage   66.79%   57.21%   -9.59%     
   ==========================================
     Files        1015      961      -54     
     Lines       49676    46994    -2682     
     Branches     4847     4379     -468     
   ==========================================
   - Hits        33183    26886    -6297     
   - Misses      16371    20108    +3737     
   + Partials      122        0     -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `46.26% <28.00%> (-4.79%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.42% <ø> (-0.58%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `68.00% <ø> (-14.15%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `50.85% <ø> (-12.18%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [418 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on a change in pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12655:
URL: https://github.com/apache/superset/pull/12655#discussion_r562432969



##########
File path: superset-frontend/spec/fixtures/mockDashboardLayout.js
##########
@@ -189,6 +189,49 @@ export const dashboardLayoutWithTabs = {
   future: [],
 };
 
+export const dashboardLayoutWithTabsCombined = {

Review comment:
       Could we have a more descriptive name here: how is this functionally different from `dashboardLayoutWithTabs`?

##########
File path: superset-frontend/spec/javascripts/dashboard/components/nativeFilters/FilterScope_spec.tsx
##########
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Provider } from 'react-redux';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import { mockStoreWithTabsCombined } from 'spec/fixtures/mockStore';
+import { Form, FormInstance } from 'src/common/components';
+import { NativeFiltersForm } from 'src/dashboard/components/nativeFilters/types';
+import FilterConfigForm from 'src/dashboard/components/nativeFilters/FilterConfigForm';
+
+describe('FilterScope', () => {
+  const save = jest.fn();
+  let form: FormInstance<NativeFiltersForm>;
+  const mockedProps = {
+    filterId: 'DefaultFilterId',
+    restore: jest.fn(),
+    parentFilters: [],
+    save,
+  };
+
+  const MockModal = ({ scope }: { scope: object | undefined }) => {
+    const [newForm] = Form.useForm<NativeFiltersForm>();
+    form = newForm;
+    if (scope) {
+      form.setFieldsValue({
+        filters: {
+          [mockedProps.filterId]: {
+            scope,
+          },
+        },
+      });
+    }
+    return (
+      <Provider store={mockStoreWithTabsCombined}>
+        <Form form={form}>
+          <FilterConfigForm form={form} {...mockedProps} />
+        </Form>
+      </Provider>
+    );
+  };
+
+  const getWrapper = (scope?: object) => {
+    render(<MockModal scope={scope} />);
+  };
+
+  const getTreeSwitcher = (order = 0) =>
+    document.querySelectorAll('.ant-tree-switcher')[order];

Review comment:
       Would be nice to add a `data-test` to the Tree switcher.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simchaNielsen commented on a change in pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
simchaNielsen commented on a change in pull request #12655:
URL: https://github.com/apache/superset/pull/12655#discussion_r563250190



##########
File path: superset-frontend/spec/javascripts/dashboard/components/nativeFilters/FilterScope_spec.tsx
##########
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import { Provider } from 'react-redux';
+import { render, screen, fireEvent } from 'spec/helpers/testing-library';
+import { mockStoreWithTabsCombined } from 'spec/fixtures/mockStore';
+import { Form, FormInstance } from 'src/common/components';
+import { NativeFiltersForm } from 'src/dashboard/components/nativeFilters/types';
+import FilterConfigForm from 'src/dashboard/components/nativeFilters/FilterConfigForm';
+
+describe('FilterScope', () => {
+  const save = jest.fn();
+  let form: FormInstance<NativeFiltersForm>;
+  const mockedProps = {
+    filterId: 'DefaultFilterId',
+    restore: jest.fn(),
+    parentFilters: [],
+    save,
+  };
+
+  const MockModal = ({ scope }: { scope: object | undefined }) => {
+    const [newForm] = Form.useForm<NativeFiltersForm>();
+    form = newForm;
+    if (scope) {
+      form.setFieldsValue({
+        filters: {
+          [mockedProps.filterId]: {
+            scope,
+          },
+        },
+      });
+    }
+    return (
+      <Provider store={mockStoreWithTabsCombined}>
+        <Form form={form}>
+          <FilterConfigForm form={form} {...mockedProps} />
+        </Form>
+      </Provider>
+    );
+  };
+
+  const getWrapper = (scope?: object) => {
+    render(<MockModal scope={scope} />);
+  };
+
+  const getTreeSwitcher = (order = 0) =>
+    document.querySelectorAll('.ant-tree-switcher')[order];

Review comment:
       I didn't find way to add `data-test` attribute to the Tree switcher, it looks like Ant don't expose such api




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (e66d87a) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `11.16%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12655       +/-   ##
   ===========================================
   - Coverage   66.79%   55.63%   -11.17%     
   ===========================================
     Files        1015      961       -54     
     Lines       49676    46994     -2682     
     Branches     4847     4379      -468     
   ===========================================
   - Hits        33183    26146     -7037     
   - Misses      16371    20848     +4477     
   + Partials      122        0      -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `41.91% <28.00%> (-9.14%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `63.42% <ø> (-0.58%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `68.00% <ø> (-14.15%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `50.85% <ø> (-12.18%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [434 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...e66d87a](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov-io edited a comment on pull request #12655: test(native-filters): scoping tree in native filters modal

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12655:
URL: https://github.com/apache/superset/pull/12655#issuecomment-764615007


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=h1) Report
   > Merging [#12655](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=desc) (1ba688e) into [master](https://codecov.io/gh/apache/superset/commit/a422c765c7601058e13dcf50d5251a166d542aec?el=desc) (a422c76) will **decrease** coverage by `22.23%`.
   > The diff coverage is `28.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12655/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12655       +/-   ##
   ===========================================
   - Coverage   66.79%   44.56%   -22.24%     
   ===========================================
     Files        1015      476      -539     
     Lines       49676    17070    -32606     
     Branches     4847     4396      -451     
   ===========================================
   - Hits        33183     7607    -25576     
   + Misses      16371     9463     -6908     
   + Partials      122        0      -122     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `44.56% <28.00%> (-6.49%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `66.66% <ø> (-15.48%)` | :arrow_down: |
   | [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `51.93% <ø> (-11.10%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `27.90% <0.00%> (-32.97%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <9.09%> (-71.53%)` | :arrow_down: |
   | [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `23.52% <22.50%> (-34.37%)` | :arrow_down: |
   | [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `64.70% <64.70%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [908 more](https://codecov.io/gh/apache/superset/pull/12655/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=footer). Last update [2463215...1ba688e](https://codecov.io/gh/apache/superset/pull/12655?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org