You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/03/25 20:26:24 UTC

[GitHub] [incubator-iceberg] xabriel commented on issue #143: Applies the Baseline plugin for iceberg-api only.

xabriel commented on issue #143: Applies the Baseline plugin for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476363488
 
 
   > Should we also have a STYLE.md file somewhere that documents what we decide? If method parameter style isn't enforced, then we should write it down.
   
   +1 to eventually document anything that a reviewer could just cite, instead of writing it manually all the time.
   
   > (or is that automatic using the idea task?)
   
   Looks like Baseline will indeed give us `./gradlew idea` and `./gradlew eclipse` to import the guidelines to IDEs: https://github.com/palantir/gradle-baseline#compalantirbaseline-idea
   
   
   Nice stuff @mccheah. LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org