You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/06/26 08:03:35 UTC
[kudu-CR] [tablet] reinforce the CountLiveRows API
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13734
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
[tablet] reinforce the CountLiveRows API
In the recent patch 13426, I found that the CountLiveRows API is
not safe after the tablet is been shut down. Though the API has
not been used by any real users except test cases, I think it's
necessary to add this patch to the 1.10.x release in progress if
it's possible.
Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/13734/1
--
To view, visit http://gerrit.cloudera.org:8080/13734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
[kudu-CR] [tablet] reinforce the CountLiveRows API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Jun 2019 18:02:25 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] reinforce the CountLiveRows API
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13734/1//COMMIT_MSG
Commit Message:
PS1:
Thanks for catching this and fixing it!
As far as I can tell, because there aren't any callers of CountLiveRows in 1.10.x, it is unused code, so I don't think this warrants cutting another release candidate.
http://gerrit.cloudera.org:8080/#/c/13734/1//COMMIT_MSG@7
PS1, Line 7: [tablet] reinforce the CountLiveRows API
What were the symptoms you saw to diagnose this issue?
--
To view, visit http://gerrit.cloudera.org:8080/13734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Jun 2019 16:29:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] reinforce the CountLiveRows API
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
Patch Set 1:
> Patch Set 1:
>
> (2 comments)
That said, I spoke with Grant and he may be cutting a new release candidate anyway.
--
To view, visit http://gerrit.cloudera.org:8080/13734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Jun 2019 18:01:22 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] reinforce the CountLiveRows API
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13734 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Jun 2019 18:01:48 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] reinforce the CountLiveRows API
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13734 )
Change subject: [tablet] reinforce the CountLiveRows API
......................................................................
[tablet] reinforce the CountLiveRows API
In the recent patch 13426, I found that the CountLiveRows API is
not safe after the tablet is been shut down. Though the API has
not been used by any real users except test cases, I think it's
necessary to add this patch to the 1.10.x release in progress if
it's possible.
Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Reviewed-on: http://gerrit.cloudera.org:8080/13734
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
2 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13734
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I56b25a6acb61564ce089be11a1605a19c25eb9e0
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)