You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2021/03/29 18:25:00 UTC
[jira] [Updated] (BEAM-10326) Combine API to increase safety when
accumulator is mutated
[ https://issues.apache.org/jira/browse/BEAM-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kenneth Knowles updated BEAM-10326:
-----------------------------------
Status: Open (was: Triage Needed)
> Combine API to increase safety when accumulator is mutated
> ----------------------------------------------------------
>
> Key: BEAM-10326
> URL: https://issues.apache.org/jira/browse/BEAM-10326
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P3
> Labels: Clarified
>
> Combine docs for e.g. {{mergeAccumulators}} say
> "only the first accumulator may be modified and returned for efficiency; the other accumulators should not be mutated, because they may be shared with other code and mutating them could lead to incorrect results or data corruption."
> This is fine, but the API is odd: {{AccumT mergeAccumulators(Iterable<AccumT> accumulators)}} implies that all accumulators are treated equally.
> It has been suggested to create a new one more like {{AccumT mergeAccumulators(AccumT mutable, Iterable<AccumT> immutableAccums)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)