You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/10 03:10:54 UTC

[GitHub] [pulsar] Anonymitaet commented on pull request #17888: [fix][conf] Fix port conflict in bookkeeper.conf

Anonymitaet commented on PR #17888:
URL: https://github.com/apache/pulsar/pull/17888#issuecomment-1272734095

   > @Anonymitaet @hangc0276 now we encounter the first PR title issue. `conf` is not in our scope candidates, if we don't sort this patch in to `conf`, shall we sort it into...`storage` (since it's config of bookkeeper)?
   > 
   > See the failure report at: https://github.com/apache/pulsar/actions/runs/3216489256/jobs/5258426561
   
   `storage` makes sense to me because `conf` involves various areas, eg, `io conf`, `fn conf`, `client conf`, `cli conf`, ....
   Each of them should belong to `io`, `fn`, `client`, `cli` rather than `conf`.
   
   Details see [[Guide] Pulsar Pull Request Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#bookmark=id.y8943h392zno) 
   <img width="746" alt="image" src="https://user-images.githubusercontent.com/50226895/194794252-9f2f91e9-eb28-4073-bd08-8cba977ca186.png">
   
   cc @D-2-Ed @DaveDuggins @momo-jun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org