You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rohit Yadav <bh...@apache.org> on 2014/12/05 19:19:53 UTC
Re: Review Request 22511: Allow use of simulator hypervisor from
client gui
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22511/#review64033
-----------------------------------------------------------
Looks like a handy feature, Leo can you send a new patch or have a discussion if we should have it? As Prasanna notes, this is not needed in production.
- Rohit Yadav
On June 12, 2014, 12:31 p.m., Leo Simons wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22511/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 12:31 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6903
> https://issues.apache.org/jira/browse/CLOUDSTACK-6903
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/CLOUDSTACK-6903 for details.
>
>
> Diffs
> -----
>
> setup/db/hypervisor_capabilities.simulator.sql 32f9aaa
> ui/scripts/system.js 7e3b457
> ui/scripts/zoneWizard.js 0a84bdb
>
> Diff: https://reviews.apache.org/r/22511/diff/
>
>
> Testing
> -------
>
> Ran
>
> mvn -Pdeveloper -pl developer -Ddeploydb
> mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> mvn -pl client jetty:run -Dsimulator
> CTRL+C
> mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> mvn -pl client jetty:run -Dsimulator
>
> Then hand-clicked in the web browser, and followed the wizard to create a new zone using the simulator hpv. (hosts must be named starting with "sim" for discovery to work).
>
> Then, re-set database, skipped the wizard and created zone/cluster/host/etc manually.
>
>
> Thanks,
>
> Leo Simons
>
>
Re: Review Request 22511: Allow use of simulator hypervisor from
client gui
Posted by Leo Simons <le...@apache.org>.
> On Dec. 5, 2014, 6:19 p.m., Rohit Yadav wrote:
> > Looks like a handy feature, Leo can you send a new patch or have a discussion if we should have it? As Prasanna notes, this is not needed in production.
Hey Rohit thanks for checking in. It looks like I commented way back when, but the reply was left as a draft due to my inability to understand reviewboard. Ugh:
> As I understand it, simulator is only shown if
> * the simulator hypervisor .jar plugin is included in the .war, and
> * the runtime config then specifies it as an available hypervisor
>
> so it's already hidden unless you're very specific about wanting to show it...?
I completely forgot about it, and since then I've had about 0 time to look at selenium testing and whatnot.
Looking at it with a bit of experience I guess we could have the simulator build go and patch up the javascript sources or something like that, but, I don't think its useful to put that in if we're not going to have tests to go with it.
So I guess we can close this for now.
- Leo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22511/#review64033
-----------------------------------------------------------
On June 12, 2014, 12:31 p.m., Leo Simons wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22511/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 12:31 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6903
> https://issues.apache.org/jira/browse/CLOUDSTACK-6903
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/CLOUDSTACK-6903 for details.
>
>
> Diffs
> -----
>
> setup/db/hypervisor_capabilities.simulator.sql 32f9aaa
> ui/scripts/system.js 7e3b457
> ui/scripts/zoneWizard.js 0a84bdb
>
> Diff: https://reviews.apache.org/r/22511/diff/
>
>
> Testing
> -------
>
> Ran
>
> mvn -Pdeveloper -pl developer -Ddeploydb
> mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> mvn -pl client jetty:run -Dsimulator
> CTRL+C
> mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> mvn -pl client jetty:run -Dsimulator
>
> Then hand-clicked in the web browser, and followed the wizard to create a new zone using the simulator hpv. (hosts must be named starting with "sim" for discovery to work).
>
> Then, re-set database, skipped the wizard and created zone/cluster/host/etc manually.
>
>
> Thanks,
>
> Leo Simons
>
>
Re: Review Request 22511: Allow use of simulator hypervisor from
client gui
Posted by Rohit Yadav <bh...@apache.org>.
> On Dec. 5, 2014, 6:19 p.m., Rohit Yadav wrote:
> > Looks like a handy feature, Leo can you send a new patch or have a discussion if we should have it? As Prasanna notes, this is not needed in production.
>
> Leo Simons wrote:
> Hey Rohit thanks for checking in. It looks like I commented way back when, but the reply was left as a draft due to my inability to understand reviewboard. Ugh:
>
> > As I understand it, simulator is only shown if
> > * the simulator hypervisor .jar plugin is included in the .war, and
> > * the runtime config then specifies it as an available hypervisor
> >
> > so it's already hidden unless you're very specific about wanting to show it...?
>
> I completely forgot about it, and since then I've had about 0 time to look at selenium testing and whatnot.
>
> Looking at it with a bit of experience I guess we could have the simulator build go and patch up the javascript sources or something like that, but, I don't think its useful to put that in if we're not going to have tests to go with it.
>
> So I guess we can close this for now.
Alright, I would still love to have the sql related change so developers can use something like cloudmonkey or psCloudStack to deploy VMs on simulator and play around.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22511/#review64033
-----------------------------------------------------------
On June 12, 2014, 12:31 p.m., Leo Simons wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22511/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 12:31 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6903
> https://issues.apache.org/jira/browse/CLOUDSTACK-6903
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/CLOUDSTACK-6903 for details.
>
>
> Diffs
> -----
>
> setup/db/hypervisor_capabilities.simulator.sql 32f9aaa
> ui/scripts/system.js 7e3b457
> ui/scripts/zoneWizard.js 0a84bdb
>
> Diff: https://reviews.apache.org/r/22511/diff/
>
>
> Testing
> -------
>
> Ran
>
> mvn -Pdeveloper -pl developer -Ddeploydb
> mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> mvn -pl client jetty:run -Dsimulator
> CTRL+C
> mvn -Pdeveloper -pl developer -Ddeploydb-simulator
> mvn -pl client jetty:run -Dsimulator
>
> Then hand-clicked in the web browser, and followed the wizard to create a new zone using the simulator hpv. (hosts must be named starting with "sim" for discovery to work).
>
> Then, re-set database, skipped the wizard and created zone/cluster/host/etc manually.
>
>
> Thanks,
>
> Leo Simons
>
>