You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jsoref <gi...@git.apache.org> on 2014/09/03 16:38:38 UTC
[GitHub] cordova-wp8 pull request: CB-7455 add bundledDependencies
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-wp8/pull/54
CB-7455 add bundledDependencies
this is the correct way to make `npm pack` happy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-wp8 cb_7455
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit d89b15394aa46e8f187d4d0341dd6782e23775c7
Author: Josh Soref <js...@blackberry.com>
Date: 2014-09-03T14:33:14Z
CB-7455 add bundledDependencies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: CB-7455 add bundledDependencies
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/54#issuecomment-54312077
If we decide to proceed this way the following commit must be reverted
https://github.com/apache/cordova-wp8/commit/98448f5f98b987c73d4af76fbce5901c383f7007
@jsoref, are there advantages of using bundledDependencies in comparison to Android where node_modules are stored in lib? I think we should try to be consistent and use the same approach where it is applicable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: CB-7455 add bundledDependencies
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/54#issuecomment-54422202
bundledDependencies does not break anything so I'm also +1 to add it; it could potentially save us from similar issue if someone decided to move node_modules back for some reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: CB-7455 add bundledDependencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: CB-7455 add bundledDependencies
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-wp8/pull/54#issuecomment-54355108
Afaict, there's no harm in having the bundledDependencies line.
From my perspective, `bundledDependencies` is the "correct" way to do it. So it's what we did for BlackBerry 10, and it's certainly the simplest thing to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-wp8 pull request: CB-7455 add bundledDependencies
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/54#issuecomment-54341288
Can we just do both? Will node still resolve bundledDependencies from inside bin/ ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---