[jira] Updated: (CASSANDRA-1570) sort is not necessary for getMaxEndpointStateVersion() in Gossiper

["iryoung jeong (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

iryoung jeong updated CASSANDRA-1570:
-------------------------------------

    Attachment: trunk-1570-1.txt
                trunk-1570-2.txt

patch trunk-1570-1.txt remove sort & patch trunk-1570-2.txt makes method simpler.

The first one is good for future features(eg, there may be new soureces for epVersion) and the second one is just simple code that works. 

I hope reviewer may choose better one. ( IMO, trunk-1570-2.txt is better.)



> sort is not necessary for getMaxEndpointStateVersion() in Gossiper
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-1570
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1570
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: iryoung jeong
>            Priority: Minor
>         Attachments: trunk-1570-1.txt, trunk-1570-2.txt
>
>
> hello, 
> while I reviewing the cassandra source code, I think, there's redundant sort in getMaxEndpointStateVersion() in Gossiper.
> To get a max value, sorting is not necessary.. isn't it?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.