You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2023/05/13 12:49:27 UTC
[GitHub] [cordova-coho] breautek opened a new pull request, #307: fix: Ignore codecov files
breautek opened a new pull request, #307:
URL: https://github.com/apache/cordova-coho/pull/307
Ignores coverage/ files
I opted to not use `coverage` as the exclude term, as I felt that's too generic/broad and may potentially exclude files that we would want to scan.
The RAT tool also doesn't appear to support a full glob syntax, so doing something like `coverage/**` doesn't work.
So finally I choose `lcov-*` and `lcov.info`, which I feel is the safest exclude terms.
These are generated files by code coverage tools and RAT states:
> Generated files do not require license headers.
Yet these files were being checked and was creating unnecessary noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] breautek merged pull request #307: fix: Ignore codecov files
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #307:
URL: https://github.com/apache/cordova-coho/pull/307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-coho] codecov-commenter commented on pull request #307: fix: Ignore codecov files
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #307:
URL: https://github.com/apache/cordova-coho/pull/307#issuecomment-1546645213
## [Codecov](https://app.codecov.io/gh/apache/cordova-coho/pull/307?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#307](https://app.codecov.io/gh/apache/cordova-coho/pull/307?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (305cd76) into [master](https://app.codecov.io/gh/apache/cordova-coho/commit/80fea9d135a2cdb7b5a6af11827cd84e37d8adcf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (80fea9d) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 56.91% 56.91%
=======================================
Files 8 8
Lines 492 492
=======================================
Hits 280 280
Misses 212 212
```
| [Impacted Files](https://app.codecov.io/gh/apache/cordova-coho/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [src/audit-license-headers.js](https://app.codecov.io/gh/apache/cordova-coho/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL2F1ZGl0LWxpY2Vuc2UtaGVhZGVycy5qcw==) | `78.26% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org