You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2016/04/18 18:00:50 UTC

[GitHub] trafficserver pull request: TS-4046: Prevent memory leak of HTTP h...

GitHub user SolidWallOfCode opened a pull request:

    https://github.com/apache/trafficserver/pull/577

    TS-4046: Prevent memory leak of HTTP heap for server intercept case.

    In the case of an intercept plugin the `client_response` can be leaked. I changed the method used to be `destroy` to be clearer and changed it to destroy the heap, not just drop the pointers.  This has been tested in production and should be isolated as there is only one place this method is invoked.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SolidWallOfCode/trafficserver ts-4046

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/577.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #577
    
----
commit f2b49f5c49adcd2df009b86685dcdb5c1d31bec3
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date:   2016-04-18T15:14:24Z

    TS-4046: Prevent memory leak of HTTP heap for server intercept case.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4046: Prevent memory leak of HTTP h...

Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/577#discussion_r60173886
  
    --- Diff: proxy/hdrs/HTTP.h ---
    @@ -796,12 +796,13 @@ HTTPHdr::create(HTTPType polarity, HdrHeap *heap)
     }
     
     inline void
    -HTTPHdr::clear()
    +HTTPHdr::destroy()
    --- End diff --
    
    I'm seeing several other usages of `HTTPHdr::clear()` such as:
    
    `Http2UpgradeContext::~Http2UpgradeContext()`
    `HttpTransactCache::calculate_quality_of_match()`
    
    And `HTTPHdr::unmarshal()` 
    
    Am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: TS-4046: Prevent memory leak of HTTP h...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/577


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---