You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2025/06/06 01:44:59 UTC

[PR] fix: support json token file format authentication [pulsar-client-go]

mattisonchao opened a new pull request, #1380:
URL: https://github.com/apache/pulsar-client-go/pull/1380

   ### Motivation
   
   
   Support JSON token file format authentication for Pulsar Admin.
   E.g: 
   ```
   {"file": "./mnt/token"}
   ```
   
   ### Modifications
   
   - Add token file format for json.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: support json token file format authentication [pulsar-client-go]

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #1380:
URL: https://github.com/apache/pulsar-client-go/pull/1380#issuecomment-2955201090

   Hi, @BewareMyPower 
   
   We should use JSON format as a primary format to configure the token with different key-value pairs. That will be more flexible.
   
   E,g:
   - {"token": "<raw-token>"}
   - {"file": "<file-path>"}
   
   But this repo has two components. 
   - client
   - admin
   
   The JSON format only works for a client, but not for the admin. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: support json token file format authentication [pulsar-client-go]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #1380:
URL: https://github.com/apache/pulsar-client-go/pull/1380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: support json token file format authentication [pulsar-client-go]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #1380:
URL: https://github.com/apache/pulsar-client-go/pull/1380#issuecomment-2955268810

   It makes sense to use the same way to configure JWT authentication for admin and client.
   
   But from the perspective of designing the API from the very beginning:
   1. One format is enough. Pure token string is enough, JSON is scalable but it's over-designed. At least the server side only processes the token string.
   2. Reading from file (or any other external data source like DB or even a topic) is unnecessary. It should be done from the application side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org